Send blob support#35
Open
CyBot wants to merge 2 commits into
Open
Conversation
mjwwit
requested changes
Jun 1, 2026
Owner
mjwwit
left a comment
mjwwit
left a comment
There was a problem hiding this comment.
I think this only adds support for Blob in the asynchronous flow, not the synchronous one. This will make the behavior unpredictable. I realize the synchronous flow code isn't nice to work on, but I can't merge it like this.
| // Node 0.4 and later won't accept empty data. Make sure it's needed. | ||
| if (data) { | ||
| if (data instanceof Blob) { | ||
| return stream.Readable.fromWeb(data.stream()).pipe(request); |
Owner
There was a problem hiding this comment.
This Node.js API only became available in Node.js 17. This project supports Node.js >=13. I'm not against raising the minimum version, but it will be a breaking change requiring a major release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support sending Blob (and File) instances