Windows fixes#34
Open
CyBot wants to merge 4 commits into
Open
Conversation
mjwwit
reviewed
Jun 1, 2026
Owner
mjwwit
left a comment
mjwwit
left a comment
There was a problem hiding this comment.
Thanks for the PR! Code looks good overall, with some final touches we can get this merged pretty quickly I think.
Comment on lines
+935
to
+936
| + " fs.writeFileSync(" + JSON.stringify(contentFile) + ", 'NODE-XMLHTTPREQUEST-ERROR-REDIRECT: Too many redirects', 'utf8');" | ||
| + " fs.unlinkSync(" + JSON.stringify(syncFile) + ");" |
Owner
There was a problem hiding this comment.
Better to put these into consts instead of calling stringify every time.
|
|
||
| // Async | ||
| var url = "file://" + __dirname + "/testdata.txt"; | ||
| var p = (__dirname + "/testdata.txt").replaceAll(path.sep, path.posix.sep); |
Owner
There was a problem hiding this comment.
I don't think replaceAll is available on Node.js 13 (the minimum supported Node.js version for this project). MDN states it's available from Node.js 15 onwards. Is there a simple alternative?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix path and URL issues when running on windows