Add step-by-step data pipeline and resumable training#1
Open
Conversation
- Add scripts/prepare_data.py: separate download (JSONL) and tokenize (.pt) steps so raw and tokenized data can be inspected independently - Update minillm/dataset.py to load pre-tokenized .pt files from disk instead of downloading and tokenizing on every run - Add --resume and --max-steps flags to scripts/train.py for incremental training with full checkpoint resumption (model, optimizer, step, best val loss) - Update README with step-by-step workflow documentation - Fix flaky test_respects_max_new_tokens test (BPE re-encode round-trip issue)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/prepare_data.pyto separate data download and tokenization into inspectable steps (data/raw/*.jsonlanddata/tokenized/*.pt)minillm/dataset.pyto load pre-tokenized.ptfiles from disk instead of re-downloading/tokenizing on every training run--resumeand--max-stepsflags toscripts/train.pyfor incremental, checkpoint-resumable trainingTest plan
python -m pytest tests/ -v)python scripts/prepare_data.pyend-to-endpython scripts/train.py --max-steps 500then resume with--resume