Make Consumer and BufferedConsumer have the same interface.#15
Open
MyGGaN wants to merge 1 commit intomixpanel:masterfrom
Open
Make Consumer and BufferedConsumer have the same interface.#15MyGGaN wants to merge 1 commit intomixpanel:masterfrom
MyGGaN wants to merge 1 commit intomixpanel:masterfrom
Conversation
Contributor
|
Great point! Thanks for this; we've got some other |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should be possible to switch between the two consumer classes provided without any code change. Currently you'll run into issues if you have implemented the
BufferedConsumer, with calls toflush()where appropriate, and then, for some reason, goes back to the defaultConsumer.My suggestion is to simply add a dummy
flush()method toConsumer. I made it static since it doesn't use self and it works great with inheritance too.