Updated so the query parameter value of zero is valid.#36
Open
mikeangstadt wants to merge 5 commits intomixdown:masterfrom
Open
Updated so the query parameter value of zero is valid.#36mikeangstadt wants to merge 5 commits intomixdown:masterfrom
mikeangstadt wants to merge 5 commits intomixdown:masterfrom
Conversation
added 3 commits
August 1, 2014 10:05
…nal parameter host.
…g. 8 out of 8 test passing.
lib/generator.js
Outdated
Member
There was a problem hiding this comment.
This was originally meant to prevent empty query params from being on the url.
So this is more explicit in dealing with types than checking undefined.
qval = qval.toString()
if (qval != "")
Author
There was a problem hiding this comment.
cool, I've made the update. thanks.
added 2 commits
January 11, 2016 09:02
Conflicts: lib/generator.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if a query param's value is numeric zero - it will not be included in a formatted URL.
This fixes the issue by explicitly testing qval.