Skip to content

fix(ci): set +e before pr-file-overlap-check so warning doesn't hard-fail #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mitwilli-create merged 1 commit into from
May 29, 2026
Merged

fix(ci): set +e before pr-file-overlap-check so warning doesn't hard-fail #321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/pr-file-overlap-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,13 @@ jobs:
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
# `bash -e` is the default for `run` blocks. Without `set +e` here,
# the node line aborts the whole script on the script's intentional
# exit-2 ("overlap detected, warn-only"), and the trailing
# `EXIT_CODE=$?` + `exit 0` never run. Workflow then reports
# failure even though the intent was a warning annotation.
# Surfaced via PR #320 2026-05-29.
set +e
node scripts/check-pr-file-overlap.mjs ${{ github.event.pull_request.number }} > /tmp/overlap-report.txt 2>/tmp/overlap-stderr.txt
EXIT_CODE=$?
cat /tmp/overlap-stderr.txt >&2
Expand Down
Loading