fix(dashboard): consistent 'Deep Refresh' capitalization across 10 user-visible labels#319
Draft
mitwilli-create wants to merge 1 commit into
Draft
Conversation
…er-visible labels [skip-ui-verify] PR #288 (2026-05-24) renamed the per-row button to "↻ Deep Refresh" + made "see log" a real hyperlink (the substantive part of F101's audit ask). This commit closes out the cosmetic-consistency tail: 10 other user-visible surfaces still used 'Deep refresh' lowercase (tooltips, modal title, aria-label, toast messages, empty-state copy, modal headers). All normalized to match. User-visible sites updated (approximate line numbers): - 3794, 3827: stale-Eval tooltips - 3846: aria-label on per-row CTA - 14088: modal h3 title - 23779: empty-state <strong> in popout - 33302: toast error message - 33329: per-row modal title body - 33403: bulk modal title body Plus 3 source-comment instances (4036, 33259) for consistency. [skip-ui-verify]: text-content-only change (no layout / CSS / DOM-structural impact). Verification via: - node scripts/build-dashboard.mjs: clean (9 inline scripts parsed) - grep -c "Deep refresh" scripts/build-dashboard.mjs: 0 - curl -s https://staging-dashboard.careers-ops.com/ | grep -c "Deep refresh": 0 - curl -s https://staging-dashboard.careers-ops.com/ | grep -c "Deep Refresh": 1127 - Chrome MCP screenshots at 1440×900 (3 captures) — full notes at .claude/audit/f101-deep-refresh-2026-05-29/notes.md Surfaced via task-audit 2026-05-29 (Theme 2 F101). Production surface — DRAFT until Mitchell reviews. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
3 tasks
mitwilli-create
added a commit
that referenced
this pull request
May 29, 2026
…fail (#321) PR #320 surfaced this: the workflow's run-block uses `bash -e` by default. The node script intentionally exits 2 when it detects critical-file overlap with another open PR (warn-only, per AGENTS.md § Bug class critical-file-parallel-pr-overlap). But `set -e` aborts the run block on the exit-2 immediately, so the trailing `EXIT_CODE=$?` + `exit 0` lines never run. Workflow reports failure even though the script's intent was to annotate the PR with a warning comment. Fix: prepend `set +e` at the top of the run block so exit-2 from the node call is captured into EXIT_CODE instead of aborting the script. The trailing `exit 0` then fires correctly, the github-script step still posts the warning comment when overlap is detected, and CI reports pass-with-warning instead of fail. Verification: - PR #320 (touches scripts/build-dashboard.mjs) + PR #319 (touches the same file) WILL produce an overlap warning under this fix — that's the intended behavior. The check will pass + post a warning comment. Surfaced via task-audit 2026-05-29 Theme-2 F104 ship. Bucket-A auto-merge per locked Q4 (workflows are NOT production-surface). Co-authored-by: Mitchell Williams <mitchellwilliams@Mitchells-MacBook-Air.local> Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize 10 in-file occurrences of
Deep refresh→Deep Refreshinscripts/build-dashboard.mjsto match the button label shipped in PR #288 on 2026-05-24.The substantive part of F101's audit ask was already shipped via PR #288 (commit
5708ed1):<a href>hyperlink (line 29348)What was missing: 10 OTHER user-visible surfaces still used
Deep refreshlowercase — tooltips, modal h3 title, aria-label, toast messages, empty-state copy, modal headers. This PR closes that consistency loop.Files touched
scripts/build-dashboard.mjsonly. 22 line changes (11 insertions, 11 deletions). All text-content only — no layout / CSS / DOM-structural impact.Verification
`[skip-ui-verify]` is in the commit message because this is a text-content-only change with zero layout risk — curl-grep against served HTML is the load-bearing proof.
Audit provenance
Surfaced via `task-audit 2026-05-29` (Theme 2 F101). Audit traced to 2026-05-27 session #1183daf9d43b. Stale-premise check found the substantive asks already shipped via PR #288.
Test plan
DRAFT until you sign off — production surface per locked Q4.
🤖 Generated with Claude Code