fix(control): refresh session-control on fork#16
Open
lajarre wants to merge 1 commit intomitsuhiko:mainfrom
Open
fix(control): refresh session-control on fork#16lajarre wants to merge 1 commit intomitsuhiko:mainfrom
lajarre wants to merge 1 commit intomitsuhiko:mainfrom
Conversation
Pi emits session_fork after assigning a new session id. Refresh the control server on that event so the socket path, footer status, and PI_SESSION_ID stay aligned with the forked session.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pi emits
session_forkafter assigning a new session id.control.tsrefreshes its state onsession_startandsession_switch, but not onsession_fork. As a result, after/forkthe control socket state can stay bound to the old session.This adds the same
refreshServer(ctx)call forsession_fork, so the session-control socket, alias/status, andPI_SESSION_IDstay aligned with the forked session.