Skip to content

Conversation

@jdyer1
Copy link

@jdyer1 jdyer1 commented May 15, 2019

Fix some little issues in oracle_database_tables.sql wrt the client_details table.

  • remove duplicated column "software_statement".
  • add column "software_version" as a varchar2 length 2048 (cf. hsql and mysql scripts)
  • fix columns "software_statement" and "software_id", should be type "varchar2" not "varchar", length 4000 (maximum allowed by oracle)
  • remove dangling comma in "saved_user_auth" table creation

@codecov-io
Copy link

codecov-io commented May 15, 2019

Codecov Report

Merging #1486 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1486   +/-   ##
=========================================
  Coverage     25.21%   25.21%           
  Complexity      912      912           
=========================================
  Files           209      209           
  Lines         11689    11689           
  Branches       2116     2116           
=========================================
  Hits           2947     2947           
  Misses         8227     8227           
  Partials        515      515

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc6bd4b...fa4e7ef. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants