Skip to content

Fix copilot review feedback on security tests #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
deacon-mp merged 1 commit into from
Mar 18, 2026
Merged

Fix copilot review feedback on security tests #55

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions tests/test_atomic_security.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@
import os

import pytest
import yaml

PLUGIN_DIR = os.path.join(os.path.dirname(__file__), '..')
yaml = pytest.importorskip("yaml")

PLUGIN_DIR = os.path.abspath(os.path.join(os.path.dirname(__file__), '..'))
ATOMIC_SVC_PATH = os.path.join(PLUGIN_DIR, 'app', 'atomic_svc.py')
PAYLOADS_DIR = os.path.join(PLUGIN_DIR, 'payloads')
DATA_DIR = os.path.join(PLUGIN_DIR, 'data')
Expand All @@ -16,7 +17,7 @@ class TestAtomicSvcMD5Security:

@pytest.fixture(autouse=True)
def _load_source(self):
with open(ATOMIC_SVC_PATH, 'r') as f:
with open(ATOMIC_SVC_PATH, 'r', encoding='utf-8') as f:
self.source = f.read()
self.tree = ast.parse(self.source)

Expand Down Expand Up @@ -53,7 +54,7 @@ def test_md5_calls_use_usedforsecurity_false(self):
"""
md5_calls = self._find_md5_calls()
for call_node in md5_calls:
keyword_names = [kw.arg for kw in call_node.keywords]
keyword_names = [kw.arg for kw in call_node.keywords if kw.arg is not None]
has_usedforsecurity = 'usedforsecurity' in keyword_names
if has_usedforsecurity:
for kw in call_node.keywords:
Expand Down Expand Up @@ -93,6 +94,11 @@ def _get_atomic_yaml_files(self):

def test_yaml_files_exist(self):
"""The atomic data directory should contain YAML test definitions."""
if not os.path.isdir(ATOMICS_DIR):
pytest.skip(
f"Atomics directory not found at {ATOMICS_DIR} — "
f"run 'git submodule update --init' to populate data"
)
yaml_files = self._get_atomic_yaml_files()
assert len(yaml_files) > 0, (
f"No YAML files found in {ATOMICS_DIR} — "
Expand All @@ -103,7 +109,7 @@ def test_yaml_files_are_parseable(self):
"""All YAML files should parse without error."""
yaml_files = self._get_atomic_yaml_files()
for fpath in yaml_files:
with open(fpath, 'r') as f:
with open(fpath, 'r', encoding='utf-8') as f:
try:
data = yaml.safe_load(f)
except yaml.YAMLError as e:
Expand All @@ -122,7 +128,7 @@ def test_yaml_files_have_required_fields(self):
basename = os.path.basename(fpath)
if not basename.startswith('T'):
continue
with open(fpath, 'r') as f:
with open(fpath, 'r', encoding='utf-8') as f:
data = yaml.safe_load(f)
assert 'attack_technique' in data, (
f"Missing 'attack_technique' in {fpath}"
Expand Down
Loading