chore(ol-superset): migrate 12 dashboard charts from virtual to physical datasets#2002
Open
blarghmatey wants to merge 2 commits intomainfrom
Open
chore(ol-superset): migrate 12 dashboard charts from virtual to physical datasets#2002blarghmatey wants to merge 2 commits intomainfrom
blarghmatey wants to merge 2 commits intomainfrom
Conversation
Replaces virtual dataset references with equivalent physical/reporting datasets that have identical column sets: - 7 charts (Course Engagement + Course Enrollment Activity dashboards): Enrollment_Activity_Counts_Dataset (virtual a9301703) -> Enrollment_Activity_Counts_Dataset reporting table (f33af055) - 2 charts (Course Engagement + Distribution of Videos Watched dashboards): marts__combined_video_engagements_w_video_counts (virtual 42f063d3) -> combined_video_engagements_counts_report (f0b79172) - 1 chart (Learner Engagement dashboard): Data_Detail_Discuss (virtual 5bab95fd) -> discussion_detail_report (ec0fc17c) - 1 chart (Learner Engagement dashboard): page_engagement_views (virtual c3182341) -> afact_course_page_engagement (68c544d7) Reduces virtual dataset chart count from 17 to 6. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ataset Chart uses capstone_ind, program_complete_days, courses_taken_in_program — none of the 3 virtual-only columns (capstone_indicator, program_completion_days, unique_courses_taken_in_program) are referenced. Safe drop-in replacement. Program_Enrollment_with_user (virtual cc496da8) -> program_enrollment_with_user_report (physical 378cfe46) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates a set of Superset chart assets from virtual datasets (SQL-defined) to equivalent physical/reporting datasets (table-backed) to reduce reliance on virtual datasets and standardize dashboards on reporting tables.
Changes:
- Updated
dataset_uuidin 12 chart YAML assets to point at physical/reporting datasets. - Migrated charts primarily to
Enrollment_Activity_Counts_Dataset(reporting),combined_video_engagements_counts_report,discussion_detail_report,afact_course_page_engagement, andprogram_enrollment_with_user_report.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/ol_superset/assets/charts/Video_Engagement_per_Section_52f9966c-2de9-41fd-b29a-ccd1781696cb.yaml | Switch chart to combined_video_engagements_counts_report physical dataset. |
| src/ol_superset/assets/charts/Distribution_of_Number_of_Videos_Watched_9bdb6168-d5c9-4651-af36-556e29f3b5db.yaml | Switch chart to combined_video_engagements_counts_report physical dataset. |
| src/ol_superset/assets/charts/Program_Enrollment_and_Certificate_d9047161-f8d8-4af2-adb0-283c74b639f2.yaml | Switch chart to program_enrollment_with_user_report physical dataset. |
| src/ol_superset/assets/charts/Page_Engagement_By_Courserun_008cffdc-9283-4daf-8507-746491486bd4.yaml | Switch chart to afact_course_page_engagement physical dataset. |
| src/ol_superset/assets/charts/Data_Detail_Discussion_39c99c2d-1290-4d37-9b0f-eef559172947.yaml | Switch chart to discussion_detail_report physical dataset. |
| src/ol_superset/assets/charts/Latest_Dashboard_Activity_Recorded_Date_af403a98-7ff4-407a-b1c9-5161ffc10522.yaml | Switch chart to reporting-backed Enrollment_Activity_Counts_Dataset. |
| src/ol_superset/assets/charts/Latest_Dashboard_Activity_Recorded_Date_582d2109-e097-4acc-a39e-f19932afa98d.yaml | Switch chart to reporting-backed Enrollment_Activity_Counts_Dataset. |
| src/ol_superset/assets/charts/Enrollment_Geography_118ba89d-4c33-4720-b22e-a2576ff93316.yaml | Switch chart to reporting-backed Enrollment_Activity_Counts_Dataset. |
| src/ol_superset/assets/charts/Enrollment_Demographics_by_Gender_e9c00f99-deb8-4a1f-99d4-d4e592b7c8db.yaml | Switch chart to reporting-backed Enrollment_Activity_Counts_Dataset. |
| src/ol_superset/assets/charts/Enrollment_Demographics_by_Education_aa6bdf8d-b5be-4142-a3fc-df4f0032189e.yaml | Switch chart to reporting-backed Enrollment_Activity_Counts_Dataset. |
| src/ol_superset/assets/charts/Enrollment_Activity_Over_Time_07019136-a885-4261-8960-cfca368642d7.yaml | Switch chart to reporting-backed Enrollment_Activity_Counts_Dataset. |
| src/ol_superset/assets/charts/Counts_by_course_run_5670e704-3dc6-4b28-a12c-20d4faabcd46.yaml | Switch chart to reporting-backed Enrollment_Activity_Counts_Dataset. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Member
Author
|
@KatelynGit @quazi-h this has been applied to QA for validation |
KatelynGit
reviewed
Mar 19, 2026
| @@ -1,7 +1,7 @@ | |||
| cache_timeout: null | |||
| certification_details: null | |||
| certified_by: null | |||
Contributor
There was a problem hiding this comment.
so this chart actually isn't being used in any dashboard- this change is not useful - the chart should just be deleted. There is a chart that is in use with the same name though so caution should be taken.
| certification_details: null | ||
| certified_by: null | ||
| dataset_uuid: c3182341-5246-40c2-8f04-885369c38093 # page_engagement_views | ||
| dataset_uuid: 68c544d7-726d-495a-bf87-81255b2e8604 # afact_course_page_engagement |
Contributor
There was a problem hiding this comment.
I'm not sure but this might break the report like other changes have when moved to this table. I'd use ol_warehouse_production_reporting .page_engagement_views_report instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates 12 dashboard charts off virtual datasets onto equivalent physical/reporting datasets with identical column sets, reducing the virtual dataset chart count from 17 → 5.
Changes
Batch 1 — exact column matches (11 charts)
Enrollment_Activity_Counts_Dataset(a9301703)Enrollment_Activity_Counts_Datasetreporting table (f33af055)marts__combined_video_engagements_w_video_counts(42f063d3)combined_video_engagements_counts_report(f0b79172)Data_Detail_Discuss(5bab95fd)discussion_detail_report(ec0fc17c)page_engagement_views(c3182341)afact_course_page_engagement(68c544d7)Batch 2 — validated column usage (1 chart)
Program_Enrollment_with_user(cc496da8) →program_enrollment_with_user_report(378cfe46)The virtual dataset has 3 columns not present in the physical table (
capstone_indicator,program_completion_days,unique_courses_taken_in_program). Inspection of the chart'sall_columnsconfirmed none of these are referenced — it uses only the canonical names (capstone_ind,program_complete_days,courses_taken_in_program) which exist in the physical dataset.Remaining virtual dataset charts (5)
These require new physical/reporting datasets before they can be migrated:
combined_enrollments_with_gender_and_date— 2 charts (Individual Enrollment Detail, Record Count): needsuser_job_title,user_industry, andcourserunenrollment_created_on_datejoined inData_Detail_Nav,Data_Detail_Problems,Data_Detail_Video— 3 charts (Learner Engagement): need reporting tables joining dimensional facts withcourse_title