Open
Conversation
6d1ffd8 to
8454595
Compare
9aea9b9 to
cc73944
Compare
| @@ -10,7 +10,7 @@ | |||
| # Usage with Helm chart: | |||
| # Set dagsterDaemon.image.repository and dagsterDaemon.image.tag in values.yaml | |||
|
|
|||
There was a problem hiding this comment.
Bug: Several pyproject.toml files were not updated to require Python 3.14, creating an inconsistency with the Docker images which now use Python 3.14.
Severity: MEDIUM
Suggested Fix
Update the requires-python setting in the root pyproject.toml, packages/ol-orchestrate-lib/pyproject.toml, and dg_projects/data_loading/pyproject.toml to require Python 3.14 (e.g., >=3.14,<3.15) to match the version used in the Docker containers.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: dg_deployments/Dockerfile.dagster-k8s#L12
Potential issue: The pull request updates the Docker images to use Python 3.14, but
several `pyproject.toml` files (in the root, `packages/ol-orchestrate-lib`, and
`dg_projects/data_loading`) were not updated to match. These files still allow for
Python `>3.13`, creating a discrepancy between local development and production
environments. This could lead to subtle bugs if code is developed against a different
Python version than what is run in the containerized production environment.
Did we get this right? 👍 / 👎 to inform future reviews.
570579d to
3ff631a
Compare
160f943 to
d2dd69a
Compare
ec6cde8 to
4118ccb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
>=3.13,<3.14→>=3.14,<3.153.13-slim-bookworm→3.14-slim-bookworm3.13-slim→3.14-slimRelease Notes
python/cpython (python)
v3.14.3Compare Source
v3.14.2Compare Source
v3.14.1Compare Source
v3.14.0Compare Source
Configuration
📅 Schedule: Branch creation - "every weekend" in timezone US/Eastern, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.