Add call to generate edX usernames on course run enroll if none exist#3398
Open
Add call to generate edX usernames on course run enroll if none exist#3398
Conversation
OpenAPI ChangesShow/hide ## Changes for v0.yaml:Unexpected changes? Ensure your branch is up-to-date with |
8106b51 to
4582c20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes mitodl/hq#10536
Description (What does it do?)
Saving an enrollment through the regular
v1/enrollmentsAPI more-or-less just callscreate_run_enrollments, which bails out if there's no edX username. This PR adds a check to see if there is a username for the user, and creates only the username if there isn't one.How can this be tested?
Automated tests should pass.
Test by:
OpenEdxUserfor the new user. (The user shouldn't exist at all in MITx Online.)/api/v1/enrollmentsendpoint, and that should work.OpenEdxUseris now created for the user. (It may or may not be synced depending on whether or not you have edX/Tutor set up and running.)Additional Context
This doesn't do anything for program enrollments because those don't hit edX.
It only makes the edX username because the
create_run_enrollmentscall will ultimately try to repair the user - it just won't get to that point unless there's a username set for them. So, since the repair call always happens, there's already a call to create the user, so there's no need to do it prematurely.