Draft
Conversation
Restrict CourseWithCourseRunsSerializer.get_courseruns to use the prefetched course runs filtered by .enrollable(), so only currently enrollable runs are returned while preserving prefetched product relations. Existing handling for org_id in the serializer context is unchanged.
OpenAPI ChangesShow/hide ## Changes for v0.yaml:Unexpected changes? Ensure your branch is up-to-date with |
for more information, see https://pre-commit.ci
…om/mitodl/mitxonline into only-return-enrollable-course-runs
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
https://github.com/mitodl/hq/issues/10496
Description (What does it do?)
Adds a filter to only return enrollable course runs as part of the response from CourseWithCourseRunsSerializer
How can this be tested?
Create a course with two course runs, one in the past and one currently open for enrollment. Visit the catalog page and verify that the start date is for the course run that's currently open for enrollment.