Merged
Conversation
OpenAPI ChangesShow/hide ## Changes for v0.yaml:Unexpected changes? Ensure your branch is up-to-date with |
| @@ -280,23 +291,25 @@ def handle(self, *args, **kwargs): # pylint: disable=unused-argument # noqa: C | |||
| is_source_run=kwargs.get("source_course", False), | |||
There was a problem hiding this comment.
Bug: The import_courserun command will crash with an unhandled Course.DoesNotExist exception if --use-specific-course is provided with a non-existent course ID.
Severity: MEDIUM
Suggested Fix
Wrap the call to import_courserun_from_edx within the import_courserun management command in a try...except Course.DoesNotExist block. In the except block, log a helpful error message indicating that the specified course was not found and continue to the next item in the loop.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: courses/management/commands/import_courserun.py#L291
Potential issue: When the `import_courserun` management command is run with the new
`--use-specific-course` argument, the `import_courserun_from_edx` function calls
`Course.objects.get()` with the provided readable ID. If this ID does not exist in the
database, a `Course.DoesNotExist` exception is raised. This exception is not handled in
either the API function or the calling management command, which will cause the command
to crash. Other parts of the same command include `try/except` blocks for similar
database lookups, indicating that error handling is the expected pattern and its absence
here is an oversight.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
James Kachel
cp-at-mit