Update dependency serialize-javascript to v7 [SECURITY]#3342
Merged
rhysyngsun merged 1 commit intomainfrom Apr 16, 2026
Merged
Conversation
OpenAPI ChangesShow/hide ## Changes for v0.yaml:Unexpected changes? Ensure your branch is up-to-date with |
ba5ead1 to
3d6f278
Compare
Comment on lines
+21032
to
+21039
| "serialize-javascript@npm:^6.0.0, serialize-javascript@npm:^6.0.2": | ||
| version: 6.0.2 | ||
| resolution: "serialize-javascript@npm:6.0.2" | ||
| dependencies: | ||
| randombytes: ^2.1.0 | ||
| checksum: c4839c6206c1d143c0f80763997a361310305751171dd95e4b57efee69b8f6edd8960a0b7fbfc45042aadff98b206d55428aee0dc276efe54f100899c7fa8ab7 | ||
| languageName: node | ||
| linkType: hard |
There was a problem hiding this comment.
Bug: The serialize-javascript dependency upgrade is incomplete. Vulnerable versions remain in the yarn.lock file due to transitive dependencies, leaving a potential security risk.
Severity: HIGH
Suggested Fix
Add a resolutions field to the root package.json file to force all transitive dependencies of serialize-javascript to resolve to the new, secure version (e.g., 7.0.3). After updating package.json, run yarn install to regenerate the yarn.lock file and ensure all instances are upgraded.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: yarn.lock#L21032-L21039
Potential issue: The pull request attempts to upgrade `serialize-javascript` to fix a
security vulnerability. However, the fix is incomplete. While the direct dependency in
`package.json` is updated, the `yarn.lock` file shows that transitive dependencies still
pull in vulnerable versions of `serialize-javascript` (e.g., `6.0.2`, `6.0.0`, `4.0.0`).
Without a `resolutions` entry in `package.json` to force all instances to the patched
version, the application remains susceptible to the original cross-site scripting (XSS)
vulnerability if any of these transitive dependencies are used in a way that serializes
user-controlled data for client-side evaluation.
Did we get this right? 👍 / 👎 to inform future reviews.
9529b13 to
39803e3
Compare
0fe9b03 to
6a64473
Compare
ca90577 to
e0b4c12
Compare
3dc2ff1 to
1926bfe
Compare
rhysyngsun
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
6.0.2→7.0.5GitHub Vulnerability Alerts
CVE-2024-11831
A flaw was found in npm-serialize-javascript. The vulnerability occurs because the serialize-javascript module does not properly sanitize certain inputs, such as regex or other JavaScript object types, allowing an attacker to inject malicious code. This code could be executed when deserialized by a web browser, causing Cross-site scripting (XSS) attacks. This issue is critical in environments where serialized data is sent to web clients, potentially compromising the security of the website or web application using this package.
Severity
CVSS:3.1/AV:N/AC:L/PR:L/UI:R/S:C/C:L/I:L/A:NGHSA-5c6j-r48x-rmvq
Impact
The serialize-javascript npm package (versions <= 7.0.2) contains a code injection vulnerability. It is an incomplete fix for CVE-2020-7660.
While
RegExp.sourceis sanitized,RegExp.flagsis interpolated directly into the generated output without escaping. A similar issue exists inDate.prototype.toISOString().If an attacker can control the input object passed to
serialize(), they can inject malicious JavaScript via the flags property of a RegExp object. When the serialized string is later evaluated (viaeval,new Function, or<script>tags), the injected code executes.Patches
The fix has been published in version 7.0.3. https://github.com/yahoo/serialize-javascript/releases/tag/v7.0.3
Severity
CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:HCVE-2026-34043
Impact
What kind of vulnerability is it?
It is a Denial of Service (DoS) vulnerability caused by CPU exhaustion. When serializing a specially crafted "array-like" object (an object that inherits from
Array.prototypebut has a very largelengthproperty), the process enters an intensive loop that consumes 100% CPU and hangs indefinitely.Who is impacted?
Applications that use
serialize-javascriptto serialize untrusted or user-controlled objects are at risk. While direct exploitation is difficult, it becomes a high-priority threat if the application is also vulnerable to Prototype Pollution or handles untrusted data via YAML Deserialization, as these could be used to inject the malicious object.Patches
Has the problem been patched?
Yes, the issue has been patched by replacing
instanceof Arraychecks withArray.isArray()and usingObject.keys()for sparse array detection.What versions should users upgrade to?
Users should upgrade to
v7.0.5or later.Workarounds
Is there a way for users to fix or remediate the vulnerability without upgrading?
There is no direct code-level workaround within the library itself. However, users can mitigate the risk by:
serialize()function.v7.0.5as soon as possible.Acknowledgements
Serialize JavaScript thanks Tomer Aberbach (@TomerAberbach) for discovering and privately disclosing this issue.
Severity
CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:N/I:N/A:HSerialize JavaScript is Vulnerable to RCE via RegExp.flags and Date.prototype.toISOString()
GHSA-5c6j-r48x-rmvq
More information
Details
Impact
The serialize-javascript npm package (versions <= 7.0.2) contains a code injection vulnerability. It is an incomplete fix for CVE-2020-7660.
While
RegExp.sourceis sanitized,RegExp.flagsis interpolated directly into the generated output without escaping. A similar issue exists inDate.prototype.toISOString().If an attacker can control the input object passed to
serialize(), they can inject malicious JavaScript via the flags property of a RegExp object. When the serialized string is later evaluated (viaeval,new Function, or<script>tags), the injected code executes.Patches
The fix has been published in version 7.0.3. https://github.com/yahoo/serialize-javascript/releases/tag/v7.0.3
Severity
CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:H/I:H/A:HReferences
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
Serialize JavaScript has CPU Exhaustion Denial of Service via crafted array-like objects
CVE-2026-34043 / GHSA-qj8w-gfj5-8c6v
More information
Details
Impact
What kind of vulnerability is it?
It is a Denial of Service (DoS) vulnerability caused by CPU exhaustion. When serializing a specially crafted "array-like" object (an object that inherits from
Array.prototypebut has a very largelengthproperty), the process enters an intensive loop that consumes 100% CPU and hangs indefinitely.Who is impacted?
Applications that use
serialize-javascriptto serialize untrusted or user-controlled objects are at risk. While direct exploitation is difficult, it becomes a high-priority threat if the application is also vulnerable to Prototype Pollution or handles untrusted data via YAML Deserialization, as these could be used to inject the malicious object.Patches
Has the problem been patched?
Yes, the issue has been patched by replacing
instanceof Arraychecks withArray.isArray()and usingObject.keys()for sparse array detection.What versions should users upgrade to?
Users should upgrade to
v7.0.5or later.Workarounds
Is there a way for users to fix or remediate the vulnerability without upgrading?
There is no direct code-level workaround within the library itself. However, users can mitigate the risk by:
serialize()function.v7.0.5as soon as possible.Acknowledgements
Serialize JavaScript thanks Tomer Aberbach (@TomerAberbach) for discovering and privately disclosing this issue.
Severity
CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:N/I:N/A:HReferences
This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).
Release Notes
yahoo/serialize-javascript (serialize-javascript)
v7.0.5Compare Source
Fixes
For more details, please see GHSA-qj8w-gfj5-8c6v.
v7.0.4Compare Source
What's Changed
Full Changelog: yahoo/serialize-javascript@v7.0.3...v7.0.4
v7.0.3Compare Source
2e609d042b7cdbv7.0.2Compare Source
What's Changed
Full Changelog: yahoo/serialize-javascript@v7.0.1...v7.0.2
v7.0.1Compare Source
What's Changed
New Contributors
Full Changelog: yahoo/serialize-javascript@v7.0.0...v7.0.1
v7.0.0Compare Source
Breaking Changes
What's Changed
New Contributors
Full Changelog: yahoo/serialize-javascript@v6.0.2...v7.0.0
Configuration
📅 Schedule: (in timezone US/Eastern)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.