Processing of TCP packets sent by the SYSTEM process using windows-redirector.exe#204
Open
sbromt wants to merge 4 commits intomitmproxy:mainfrom
Open
Processing of TCP packets sent by the SYSTEM process using windows-redirector.exe#204sbromt wants to merge 4 commits intomitmproxy:mainfrom
sbromt wants to merge 4 commits intomitmproxy:mainfrom
Conversation
Author
|
I submitted a pull request, but it seems there has been no response so far. What should I do next? |
Member
|
@sbromt: thanks - you're all good. We're a bit short on reviewers on Windows, but I'll try to get to your patch in the next week or so. |
Author
|
@mhils Has there been any progress regarding this matter? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When accessing the NAS through Windows Explorer, the TCP handshake packets from the System process (PID=4) are held at the if block on line 188 of the main2.rs. However, when a socket event occurs, processing is skipped at the if block on line 232 of the main2.rs, preventing Windows Explorer from establishing a TCP connection.
Wouldn't it be better to reinject the connections held in connections back into the network before skipping them, even if the process is the System process?