This repository was archived by the owner on Oct 31, 2023. It is now read-only.
Unset $GOOS and $GOARCH before setting#88
Open
Equim-chan wants to merge 1 commit intomitchellh:masterfrom
Open
Unset $GOOS and $GOARCH before setting#88Equim-chan wants to merge 1 commit intomitchellh:masterfrom
Equim-chan wants to merge 1 commit intomitchellh:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue I found when I was writing a build tool driven by
go generateon my own project sha3sum.tl;dr
go generateinjects $GOOS and $GOARCH variables, leading to this issue.The reproduction of the issue is as follows:
$GOPATH/src tree:
$GOPATH/src/gox-issue/main.go:
$GOPATH/src/gox-issue/build/main.go:
Now we do:
And the issue shows up: