Update to Blockly 11 by mjgallag · Pull Request #3588 · mit-cml/appinventor-sources

mjgallag · 2025-09-05T22:06:54Z

General items:

I have updated the relevant documentation files under docs/
My code follows the:
- Google Java style guide (for .java files)
- Google JavaScript style guide (for .js files)
ant tests passes on my machine

If your code changes how something works on the device (i.e., it affects the companion):

I branched from ucr
My pull request has ucr as the base

Further, if you've changed the blocks language or another user-facing designer/blocks API (added a SimpleProperty, etc.):

I have updated the corresponding version number in appinventor/components/src/.../common/YaVersion.java
I have updated the corresponding upgrader in appinventor/appengine/src/.../client/youngandroid/YoungAndroidFormUpgrader.java (components only)
I have updated the corresponding entries in appinventor/blocklyeditor/src/versioning.js

For all other changes:

I branched from master
My pull request has master as the base

What does this PR accomplish?

Resolves #3434, Resolves #3529, Resolves #3530, Resolves #3531, Resolves #3532

mjgallag · 2025-09-05T22:33:01Z

I just found a bug that I'll work on next. While delete count is correct (includes children too) when selecting multiple blocks only the block (and its children, if any) you right click on is deleted.

ewpatton · 2025-09-05T22:40:07Z

Is this true in master as well? In either case the issue will be somewhere in the multi select plugin.Sent from my iPhoneOn Sep 5, 2025, at 18:33, Michael Gallagher ***@***.***> wrote:mjgallag left a comment (mit-cml/appinventor-sources#3588) I just found a bug that I'll work on next. While delete count is correct (includes children too) when selecting multiple blocks only the block (and its children, if any) you right click on is deleted. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

mjgallag · 2025-09-05T22:42:43Z

@ewpatton it works in master so I either messed up the merge mit-cml/workspace-multiselect@main...mjgallag:workspace-multiselect:update-to-blockly-11 or its a Blockly 11 issue with the plugin.

mjgallag · 2025-09-06T01:57:38Z

@ewpatton its reproducible on main branch of multiselect plugin but works if I try commit before it was upgraded to Blockly 11.

mjgallag · 2025-09-06T02:26:32Z

@ewpatton ha ... now i'm not so sure about any of my statements regarding this bug ... tbd

mjgallag · 2025-09-06T21:07:10Z

Ah ha, it's a subtle bug that was introduced when the multiselect plugin was upgraded to Blockly 11. If you keep the shift key pressed when you right click the yellow borders of multiple select are lost and even though context menu has correct multiple counts it only acts on block you right clicked. If you let go of shift key after making your selections and before right clicking it works as expected. Will look into this but will get test instance up first so people can play with it in parallel with my bug fixing.

mjgallag · 2025-09-06T22:00:08Z

mit-cml/workspace-multiselect#112

mjgallag · 2025-09-08T19:03:21Z

https://arched-branch-471517-f9.uc.r.appspot.com/ here is an appspot instance for playing around with this

mjgallag · 2025-09-14T22:35:56Z

OK that bug is fixed and https://arched-branch-471517-f9.uc.r.appspot.com/ has been updated. Also there is no more fork for multiselect. I have marked this ready for review. I expect more bugs will probably be found but I think it's ready for more eyes.

mjgallag · 2025-09-16T20:05:45Z

I just noticed with https://appinventor.mit.edu/explore/tips/typeblocking the blocks are landing on top of each other in this branch instead of staggered like on master. @josmas I think I am going to try to integrate your plugin https://github.com/josmas/blockly-plugins/tree/feat/typeblocking as part of this Blockly 11 branch.

mjgallag · 2025-09-19T00:34:09Z

Nevermind I just fixed the bugs as moving to @josmas typeblocking plugin should be a separate pull. This bug lead me to fix the same bug in a few different places and also lead me to notice paste from backapck was broken, that fix was pretty interesting. In any case https://arched-branch-471517-f9.uc.r.appspot.com/ has been updated. I am off next week and a half. If anyone gets around to testing this please leave bugs in the comments for my return. But as of now I have fixed all I have discovered.

mjgallag · 2025-10-25T23:29:20Z

test server has been updated (https://arched-branch-471517-f9.uc.r.appspot.com/)

RaspberryPiFoundation/blockly@75007a0#diff-bb0de0069443e7577f62ffa96e6b51c5fafd06703f50c3eed6eb616ac87467bfL118-L124 https://developers.google.com/blockly/reference/js/blockly.blocksvg_class.setwarningtext_1_method.md setWarningText checks for warning icon https://github.com/google/blockly/blob/blockly-v11.2.2/core/block_svg.ts#L972

Change-Id: I82772409263bc5168ceb02a12d196cc1913757c0

RaspberryPiFoundation/blockly@e91dd20#diff-faf2e97315fe0f985ed0bb8d8412638b74af99427705125ac5b5bd08863dea32L129-R130

RaspberryPiFoundation/blockly@75007a0#diff-f42a81c6c2b6acc214eb89673af86be8d046a0a092e0996a8d120f64863927daL148-L157

RaspberryPiFoundation/blockly@75007a0#diff-aeb28553e3f549c3f6fcdeb09b161c70732f73df152f7e7dccd36fe535fc49f0L358-L376

ewpatton · 2026-03-12T22:02:04Z

    'zoom': {'controls': true, 'wheel': true, 'scaleSpeed': 1.1, 'maxScale': 3, 'minScale': 0.1},
    plugins: {
-      blockDragger: MultiselectBlockDragger,
+      blockDragger: ScrollBlockDragger,


@mjgallag I'm worried that this changes the semantics of dragging. How do we end up allowing dragging multiple blocks if they are selected?

The multiselect plugin no longer needs a custom block dragger. It was rewritten for Blockly v11 to use the IDraggable interface. MultiselectDraggable wraps selected blocks into a single draggable instead of extending BlockDragger. So ScrollBlockDragger in the dragger slot is just for auto-scrolling during drag, it doesn't touch multi-select which is handled at the draggable level.

There's a Playwright e2e test ("dragging moves selected blocks together") that covers this.

ewpatton · 2026-03-12T22:12:33Z

+        return original(png);
+      };
+    });
+    Blockly.exportBlockAsPng(block);


Note that at least on my machine, this triggers the PNG to show up in my Downloads folder. We probably don't want a test that leaks files outside of the build directory.

Good find! #3804

ewpatton · 2026-03-12T22:17:01Z

 <script src="block.js"></script>
 <script src="text.js"></script>
 <script src="../../../../../build/javascript/BlocklyEvalTest.js"></script>
+<script src="../../../../../build/javascript/xml_serialization_tests.js"></script>


Note that we should probably also add the other tests here to be able to use mocha in the browser. Also, two tests fail due to the lack of FieldColour.

Ah, had I run the tests in Mocha I would have noticed the blocks download! #3805

ewpatton

I'm approving this so we can move the release forward. Most of my comments are related to the test apparatus, which we can solve in a separate PR.

mjgallag force-pushed the update-to-blockly-11 branch from 8eb92fc to 785162b Compare September 11, 2025 14:57

mjgallag mentioned this pull request Sep 13, 2025

Preserve multiselection when shift held on right click mit-cml/workspace-multiselect#117

Merged

1 task

mjgallag force-pushed the update-to-blockly-11 branch 2 times, most recently from aba67f3 to ca30347 Compare September 14, 2025 21:59

mjgallag marked this pull request as ready for review September 14, 2025 22:33

mjgallag requested a review from a team September 16, 2025 15:00

mjgallag force-pushed the update-to-blockly-11 branch 2 times, most recently from 9e5b36b to 4903e4d Compare September 19, 2025 00:12

mjgallag force-pushed the update-to-blockly-11 branch from 4903e4d to 679af08 Compare September 19, 2025 02:21

mjgallag mentioned this pull request Sep 19, 2025

replace color picked by color wheel #762

Open

mjgallag added this to Blockly v11 Update Oct 10, 2025

mjgallag moved this to In Review in Blockly v11 Update Oct 10, 2025

mjgallag mentioned this pull request Oct 16, 2025

Add Blockly TypeBlocking plugin #3625

Merged

12 tasks

mjgallag force-pushed the update-to-blockly-11 branch from 679af08 to 1ab15c3 Compare October 16, 2025 23:18

mjgallag mentioned this pull request Oct 21, 2025

Fix ant BlocklyTest dependencies #3626

Closed

12 tasks

mjgallag force-pushed the update-to-blockly-11 branch 2 times, most recently from e80831a to 0499194 Compare October 23, 2025 00:30

mjgallag mentioned this pull request Oct 24, 2025

Remove dead BlockSvg extensions code #3630

Closed

12 tasks

mjgallag force-pushed the update-to-blockly-11 branch from 9e80046 to ddcb7b0 Compare January 4, 2026 16:57

ewpatton reviewed Jan 13, 2026

View reviewed changes

Comment thread appinventor/blocklyeditor/src/blocks/components.js

ewpatton reviewed Jan 13, 2026

View reviewed changes

Comment thread appinventor/blocklyeditor/src/blocks/dictionaries.js

ewpatton reviewed Jan 13, 2026

View reviewed changes

Comment thread appinventor/blocklyeditor/src/blocks/lexical-variables.js

mjgallag added 2 commits January 13, 2026 07:30

Remove old commented out code from rename functions

c076ddc

ewpatton reviewed Jan 22, 2026

View reviewed changes

Comment thread appinventor/blocklyeditor/src/generators/yail.js Outdated

ewpatton and others added 2 commits January 27, 2026 17:31

Fix issue with blockToCode only generating a single line

b661f05

Change-Id: I82772409263bc5168ceb02a12d196cc1913757c0

Change comment bubble textarea CSS selector

0c383a1

RaspberryPiFoundation/blockly@e91dd20#diff-faf2e97315fe0f985ed0bb8d8412638b74af99427705125ac5b5bd08863dea32L129-R130

mjgallag force-pushed the update-to-blockly-11 branch from 7dda2ea to 0c383a1 Compare January 28, 2026 01:32

mjgallag added 2 commits January 27, 2026 18:43

Remove unnecessary blockToCode shim

5b73a1b

Update to workspace-multiselect pr120-44c2447

9c01e1a

mjgallag mentioned this pull request Feb 12, 2026

Clear multi selection when selecting blocks not in selection mit-cml/workspace-multiselect#120

Merged

jisqyv added on ai2-test Code is deployed on ai2-test.appinventor.mit.edu and removed on ai2-test Code is deployed on ai2-test.appinventor.mit.edu labels Feb 13, 2026

mjgallag added 6 commits February 17, 2026 15:39

Change Icon setVisible() to setBubbleVisible()

cc04b6c

RaspberryPiFoundation/blockly@75007a0#diff-f42a81c6c2b6acc214eb89673af86be8d046a0a092e0996a8d120f64863927daL148-L157

Change reconnect() from MutatorIcon to Connection

2846184

RaspberryPiFoundation/blockly@75007a0#diff-aeb28553e3f549c3f6fcdeb09b161c70732f73df152f7e7dccd36fe535fc49f0L358-L376

Update to workspace-multiselect pr122-9cc46a1

048c8c5

Remove flaky multiselect tests

92c0798

Update to workspace-multiselect pr125-a25cfb2

ca0e920

Update to workspace-multiselect pr126-e813d3a

50a952f

ewpatton self-assigned this Mar 11, 2026

ewpatton reviewed Mar 12, 2026

View reviewed changes

ewpatton approved these changes Mar 12, 2026

View reviewed changes

ewpatton merged commit 07dc794 into mit-cml:master Mar 12, 2026
2 checks passed

github-project-automation Bot moved this from In Review to Done in Blockly v11 Update Mar 12, 2026

mjgallag mentioned this pull request Mar 13, 2026

Improve export blocks image test #3804

Merged

12 tasks

mjgallag deleted the update-to-blockly-11 branch March 13, 2026 18:10

Uh oh!

Conversation

mjgallag commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mjgallag commented Sep 5, 2025

Uh oh!

ewpatton commented Sep 5, 2025 via email

Uh oh!

mjgallag commented Sep 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mjgallag commented Sep 6, 2025

Uh oh!

mjgallag commented Sep 6, 2025

Uh oh!

mjgallag commented Sep 6, 2025

Uh oh!

mjgallag commented Sep 6, 2025

Uh oh!

mjgallag commented Sep 8, 2025

Uh oh!

mjgallag commented Sep 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mjgallag commented Sep 16, 2025

Uh oh!

mjgallag commented Sep 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mjgallag commented Oct 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ewpatton Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

mjgallag Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

ewpatton Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

mjgallag Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

ewpatton Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

mjgallag Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

ewpatton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mjgallag commented Sep 5, 2025 •

edited

Loading

mjgallag commented Sep 5, 2025 •

edited

Loading

mjgallag commented Sep 14, 2025 •

edited

Loading

mjgallag commented Sep 19, 2025 •

edited

Loading