Skip to content

Updating package.#32

Open
Fazendaaa wants to merge 7 commits intomisterhat:masterfrom
Fazendaaa:master
Open

Updating package.#32
Fazendaaa wants to merge 7 commits intomisterhat:masterfrom
Fazendaaa:master

Conversation

@Fazendaaa
Copy link

@Fazendaaa Fazendaaa commented Oct 7, 2018

Hey, @misterhat. Thanks for this awesome package!

Due to Hacktoberfest 2018, I'm contributing to some packages that I use; yours is one of those.

I was going to only make TypeScript(TS) typings to your package, but since it was an old package I've decided to make some changes:

  • Using promises instead of callbacks;
  • Removing ALL packages dependencies, making it less likely to need to update it in a near future;
  • Added a .npmignore;
  • Rewriting in TS;
  • Integrating linter standards;
  • Setting git hooks with Husky;
  • Using Webpack to handle file integration;
  • Writing new and more comprehensive tests with Jest;
  • Continuous Integrations (CI) with:
    • Travis CI
    • Codecov
    • Codeclimate
  • Updating docs;
  • Making use of typedoc to integrate with Github pages -- https://fazendaaa.github.io/omdb/;
  • Linked typings file in your package.json -- making no need to submit to @types;

TODO:

[ ] If you decided to accept this PR, please be aware of modifying the README.md, a simple regex replacing all of Fazendaaa to misterhat gets the job done;
[ ] Create an account, if not existing, in all of the CI services -- they are free for Open Source projects;
[ ] Just go to your repo settings and activate the Github pages options.

That's it, thanks again and keep doing this awesome work :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant