Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, @misterhat. Thanks for this awesome package!
Due to Hacktoberfest 2018, I'm contributing to some packages that I use; yours is one of those.
I was going to only make TypeScript(TS) typings to your package, but since it was an old package I've decided to make some changes:
TODO:
[ ] If you decided to accept this PR, please be aware of modifying the README.md, a simple regex replacing all of
Fazendaaatomisterhatgets the job done;[ ] Create an account, if not existing, in all of the CI services -- they are free for Open Source projects;
[ ] Just go to your repo settings and activate the Github pages options.
That's it, thanks again and keep doing this awesome work :)