Skip to content

enhance(frontend): 絵文字メニューから直接絵文字パレットに追加できるように#17420

Open
kakkokari-gtyih wants to merge 6 commits into
misskey-dev:developfrom
kakkokari-gtyih:enh-17419
Open

enhance(frontend): 絵文字メニューから直接絵文字パレットに追加できるように#17420
kakkokari-gtyih wants to merge 6 commits into
misskey-dev:developfrom
kakkokari-gtyih:enh-17419

Conversation

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor

@kakkokari-gtyih kakkokari-gtyih commented May 17, 2026

What

追加
もうある場合はconfirmののち削除可能

image image image image

Why

Fix #17419

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 17, 2026
@github-actions github-actions Bot added the packages/frontend Client side specific issue/PR label May 17, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 17, 2026

Codecov Report

❌ Patch coverage is 0% with 57 lines in your changes missing coverage. Please review.
✅ Project coverage is 15.21%. Comparing base (c864349) to head (637b93b).

Files with missing lines Patch % Lines
packages/frontend/src/utility/emoji-palette.ts 0.00% 27 Missing and 8 partials ⚠️
...ackages/frontend/src/components/global/MkEmoji.vue 0.00% 9 Missing and 1 partial ⚠️
...tend/src/components/MkReactionsViewer.reaction.vue 0.00% 2 Missing and 2 partials ⚠️
...s/frontend/src/components/global/MkCustomEmoji.vue 0.00% 3 Missing and 1 partial ⚠️
packages/frontend/src/utility/emoji-picker.ts 0.00% 1 Missing and 1 partial ⚠️
packages/frontend/src/utility/reaction-picker.ts 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17420      +/-   ##
===========================================
- Coverage    15.27%   15.21%   -0.06%     
===========================================
  Files          247      248       +1     
  Lines        12338    12386      +48     
  Branches      4178     4194      +16     
===========================================
  Hits          1885     1885              
- Misses        8188     8224      +36     
- Partials      2265     2277      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor Author

👀

@syuilo
Copy link
Copy Markdown
Member

syuilo commented May 27, 2026

パレットに追加しようとして削除をしたい時ってあるかしら

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor Author

kakkokari-gtyih commented May 27, 2026

パレットに追加しようとして削除をしたい時ってあるかしら

すでに追加されているかどうかは追加先パレットを選ぶまでわからないのでメニューそのものを消すことはできず、だからといって「すでに追加されています [OK]」みたいなのが出てきても無駄感が出そうだなと思ったので逆の操作を追加した(操作ミスなら確認画面上でキャンセルを押せるしマイナスにはならないと思われる)

@syuilo
Copy link
Copy Markdown
Member

syuilo commented May 28, 2026

多分嬉しいのはすでに追加されていた場合一旦削除してから改めて追加する動作と思われる

@syuilo
Copy link
Copy Markdown
Member

syuilo commented May 28, 2026

Amazonの欲しいものリストと同じ

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/frontend Client side specific issue/PR size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

絵文字の副メニューから絵文字パレットに絵文字を追加できるようにする

2 participants