enhance(frontend): 絵文字メニューから直接絵文字パレットに追加できるように#17420
Open
kakkokari-gtyih wants to merge 6 commits into
Open
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #17420 +/- ##
===========================================
- Coverage 15.27% 15.21% -0.06%
===========================================
Files 247 248 +1
Lines 12338 12386 +48
Branches 4178 4194 +16
===========================================
Hits 1885 1885
- Misses 8188 8224 +36
- Partials 2265 2277 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
👀 |
Member
|
パレットに追加しようとして削除をしたい時ってあるかしら |
Contributor
Author
すでに追加されているかどうかは追加先パレットを選ぶまでわからないのでメニューそのものを消すことはできず、だからといって「すでに追加されています [OK]」みたいなのが出てきても無駄感が出そうだなと思ったので逆の操作を追加した(操作ミスなら確認画面上でキャンセルを押せるしマイナスにはならないと思われる) |
Member
|
多分嬉しいのはすでに追加されていた場合一旦削除してから改めて追加する動作と思われる |
Member
|
Amazonの欲しいものリストと同じ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
追加
もうある場合はconfirmののち削除可能
Why
Fix #17419
Additional info (optional)
Checklist