Skip to content

fix(frontend): URLプレイヤーウィンドウでiframeが読み込まれるまでの間にinvalid urlと表示される問題を修正#17417

Merged
syuilo merged 7 commits into
misskey-dev:developfrom
kakkokari-gtyih:fix-player-invalid-url
May 28, 2026
Merged

fix(frontend): URLプレイヤーウィンドウでiframeが読み込まれるまでの間にinvalid urlと表示される問題を修正#17417
syuilo merged 7 commits into
misskey-dev:developfrom
kakkokari-gtyih:fix-player-invalid-url

Conversation

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor

@kakkokari-gtyih kakkokari-gtyih commented May 17, 2026

What

  • URLプレイヤーウィンドウでiframeが読み込まれるまでの間にinvalid urlと表示される問題を修正
  • URLプレイヤーウィンドウに対してそのままSummalyResultを渡すこともできるように(fetch一回解消)

Why

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 17, 2026
@github-actions github-actions Bot added the packages/frontend Client side specific issue/PR label May 17, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 17, 2026

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 15.22%. Comparing base (89ae64b) to head (7fdc158).
⚠️ Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
packages/frontend/src/components/MkUrlPreview.vue 90.90% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17417      +/-   ##
===========================================
- Coverage    22.81%   15.22%   -7.60%     
===========================================
  Files         1160      247     -913     
  Lines        39655    12349   -27306     
  Branches     11015     4192    -6823     
===========================================
- Hits          9048     1880    -7168     
+ Misses       24585     8196   -16389     
+ Partials      6022     2273    -3749     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor Author

👀

@syuilo syuilo merged commit 7e0eb61 into misskey-dev:develop May 28, 2026
8 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in [実験中] 管理用 May 28, 2026
@syuilo
Copy link
Copy Markdown
Member

syuilo commented May 28, 2026

👍

@kakkokari-gtyih kakkokari-gtyih deleted the fix-player-invalid-url branch May 28, 2026 13:50
q0w0qeeq pushed a commit to q0w0qeeq/misskey that referenced this pull request May 28, 2026
…misskey-dev#17417)

* fix(frontend): URLプレイヤーウィンドウでiframeが読み込まれるまでの間にinvalid urlと表示される問題を修正

* Update Changelog

* fix

* fix lint

* Update Changelog

---------

Co-authored-by: syuilo <4439005+syuilo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/frontend Client side specific issue/PR size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

2 participants