Skip to content

enhance(backend/oauth2): oauth2orizeを削除#17415

Draft
kakkokari-gtyih wants to merge 11 commits into
misskey-dev:developfrom
kakkokari-gtyih:enh-16896-2
Draft

enhance(backend/oauth2): oauth2orizeを削除#17415
kakkokari-gtyih wants to merge 11 commits into
misskey-dev:developfrom
kakkokari-gtyih:enh-16896-2

Conversation

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor

@kakkokari-gtyih kakkokari-gtyih commented May 16, 2026

What

  • oauth2orize を削除
    • @node-oauth/oauth2-server に置き換えて、各種メソッド等も寄せるという風に書いてあったけど、一旦保留
    • これにより oauth2orize に依存していた @fastify/express, body-parser, oauth2orize-pkce, pkce-challenge が dependency から消えた

Why

Fix #16896

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 16, 2026

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@codecov
Copy link
Copy Markdown

codecov Bot commented May 16, 2026

Codecov Report

❌ Patch coverage is 0% with 230 lines in your changes missing coverage. Please review.
✅ Project coverage is 24.96%. Comparing base (1cd6c9e) to head (069eac1).

Files with missing lines Patch % Lines
.../backend/src/server/oauth/OAuth2ProviderService.ts 0.00% 173 Missing and 35 partials ⚠️
packages/backend/src/server/oauth/errors.ts 0.00% 21 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17415      +/-   ##
===========================================
+ Coverage    15.27%   24.96%   +9.68%     
===========================================
  Files          247     1159     +912     
  Lines        12338    39526   +27188     
  Branches      4178    11001    +6823     
===========================================
+ Hits          1885     9866    +7981     
- Misses        8188    23771   +15583     
- Partials      2265     5889    +3624     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 16, 2026

Backend memory usage comparison

Before GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 307.94 MB 323.08 MB +15.14 MB +4.91%
VmHWM 307.94 MB 323.08 MB +15.14 MB +4.91%
VmSize 23172.40 MB 23169.87 MB -2.53 MB -0.01%
VmData 1373.09 MB 1369.89 MB -3.19 MB -0.23%

After GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 308.01 MB 323.10 MB +15.08 MB +4.89%
VmHWM 308.01 MB 323.10 MB +15.08 MB +4.89%
VmSize 23172.74 MB 23170.20 MB -2.53 MB -0.01%
VmData 1373.42 MB 1370.23 MB -3.19 MB -0.23%

After Request

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 308.52 MB 323.64 MB +15.12 MB +4.90%
VmHWM 308.52 MB 323.64 MB +15.12 MB +4.90%
VmSize 23172.90 MB 23170.37 MB -2.53 MB -0.01%
VmData 1373.59 MB 1370.39 MB -3.19 MB -0.23%

See workflow logs for details

@kakkokari-gtyih kakkokari-gtyih changed the title enhance(backend/oauth2): oauth2orizeをoidc-providerに置き換え (wip) enhance(backend/oauth2): oauth2orizeをoidc-providerに置き換え May 16, 2026
@kakkokari-gtyih kakkokari-gtyih changed the title enhance(backend/oauth2): oauth2orizeをoidc-providerに置き換え enhance(backend/oauth2): oauth2orizeを削除 May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/backend:test packages/backend Server side specific issue/PR

Projects

Development

Successfully merging this pull request may close these issues.

oauth2orizeをやめる

1 participant