refactor(backend): UserBlockingService <-> UserFollowingService 双方向循環を解消#17413
Open
samunohito wants to merge 2 commits into
Open
refactor(backend): UserBlockingService <-> UserFollowingService 双方向循環を解消#17413samunohito wants to merge 2 commits into
samunohito wants to merge 2 commits into
Conversation
1 task
Contributor
|
このPRによるapi.jsonの差分 |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #17413 +/- ##
========================================
Coverage 24.82% 24.82%
========================================
Files 1156 1157 +1
Lines 39330 39347 +17
Branches 10952 10949 -3
========================================
+ Hits 9762 9768 +6
- Misses 23694 23704 +10
- Partials 5874 5875 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Backend memory usage comparisonBefore GC
After GC
After Request
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
#17412 のサンプルとして、UserBlockingService <-> UserFollowingService の双方向循環参照を解消しました。
データアクセス・キャッシュ保持を責務とした BlockingDataAccessService を作成することで、Blocking / Following がそれぞれ互いを知らなくても良くなりました。
Why
#17412
Additional info (optional)
このprは、「17412をどう実現するのか」のサンプルとしての意味合いが強いです。
そもそもの方針としてダメそうであれば、issue/prともにclose頂けると助かります
Checklist