Skip to content

revert(backend): revert compile-config#17411

Open
kakkokari-gtyih wants to merge 6 commits into
misskey-dev:developfrom
kakkokari-gtyih:revert-compile-config
Open

revert(backend): revert compile-config#17411
kakkokari-gtyih wants to merge 6 commits into
misskey-dev:developfrom
kakkokari-gtyih:revert-compile-config

Conversation

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor

@kakkokari-gtyih kakkokari-gtyih commented May 15, 2026

What

Why

Fix #17407
Fix #17075

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 24.80%. Comparing base (e6375fb) to head (5f74375).

Files with missing lines Patch % Lines
packages/backend/src/config.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17411      +/-   ##
===========================================
- Coverage    24.82%   24.80%   -0.02%     
===========================================
  Files         1156     1156              
  Lines        39330    39329       -1     
  Branches     10952    10949       -3     
===========================================
- Hits          9762     9757       -5     
- Misses       23694    23697       +3     
- Partials      5874     5875       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2026

Backend memory usage comparison

Before GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 305.48 MB 300.50 MB -4.98 MB -1.63%
VmHWM 305.48 MB 300.50 MB -4.98 MB -1.63%
VmSize 23170.16 MB 23165.15 MB -5.00 MB -0.02%
VmData 1370.35 MB 1365.10 MB -5.24 MB -0.38%

After GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 305.65 MB 300.80 MB -4.84 MB -1.58%
VmHWM 305.65 MB 300.80 MB -4.84 MB -1.58%
VmSize 23170.24 MB 23165.40 MB -4.84 MB -0.02%
VmData 1370.43 MB 1365.35 MB -5.08 MB -0.37%

After Request

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 306.12 MB 301.31 MB -4.81 MB -1.57%
VmHWM 306.12 MB 301.31 MB -4.81 MB -1.57%
VmSize 23170.32 MB 23165.65 MB -4.67 MB -0.02%
VmData 1370.51 MB 1365.76 MB -4.75 MB -0.34%

See workflow logs for details

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review May 15, 2026 08:44
@dosubot dosubot Bot added the size:L This PR changes 100-499 lines, ignoring generated files. label May 15, 2026
@anatawa12 anatawa12 linked an issue May 15, 2026 that may be closed by this pull request
1 task
@anatawa12
Copy link
Copy Markdown
Member

17075 リンクしました

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor Author

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/backend:test packages/backend Server side specific issue/PR size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

compile-config の廃止提案 Add environment variable for JSON config

2 participants