Skip to content

fix: prevent local-only emoji on remote renotes#17406

Open
samunohito wants to merge 1 commit into
misskey-dev:developfrom
samunohito:fix/local-only-reaction-quote-renote
Open

fix: prevent local-only emoji on remote renotes#17406
samunohito wants to merge 1 commit into
misskey-dev:developfrom
samunohito:fix/local-only-reaction-quote-renote

Conversation

@samunohito
Copy link
Copy Markdown
Member

What

リノートされたリモートノートへのローカル限定絵文字によるリアクションを塞ぎました

Why

fix #17403

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions
Copy link
Copy Markdown
Contributor

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 24.97%. Comparing base (e6375fb) to head (0e0ba71).
⚠️ Report is 11 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #17406      +/-   ##
===========================================
+ Coverage    24.82%   24.97%   +0.15%     
===========================================
  Files         1156     1155       -1     
  Lines        39330    39314      -16     
  Branches     10952    10945       -7     
===========================================
+ Hits          9762     9819      +57     
+ Misses       23694    23648      -46     
+ Partials      5874     5847      -27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

Backend memory usage comparison

Before GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 300.76 MB 309.44 MB +8.68 MB +2.88%
VmHWM 300.76 MB 309.44 MB +8.68 MB +2.88%
VmSize 23165.93 MB 23174.38 MB +8.44 MB +0.03%
VmData 1365.68 MB 1374.48 MB +8.80 MB +0.64%

After GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 300.87 MB 309.45 MB +8.58 MB +2.85%
VmHWM 300.87 MB 309.45 MB +8.58 MB +2.85%
VmSize 23166.18 MB 23174.38 MB +8.19 MB +0.03%
VmData 1365.93 MB 1374.48 MB +8.55 MB +0.62%

After Request

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 301.52 MB 309.78 MB +8.26 MB +2.74%
VmHWM 301.52 MB 309.78 MB +8.26 MB +2.74%
VmSize 23166.52 MB 23174.38 MB +7.86 MB +0.03%
VmData 1366.26 MB 1374.48 MB +8.21 MB +0.60%

See workflow logs for details

@samunohito samunohito marked this pull request as ready for review May 19, 2026 00:43
@dosubot dosubot Bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/backend:test packages/backend Server side specific issue/PR packages/frontend Client side specific issue/PR size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

ローカル限定絵文字でリモートノートのリノートにリアクションできてしまう

1 participant