Skip to content

support node 26#17405

Draft
syuilo wants to merge 2 commits into
developfrom
syuilo-patch-1
Draft

support node 26#17405
syuilo wants to merge 2 commits into
developfrom
syuilo-patch-1

Conversation

@syuilo
Copy link
Copy Markdown
Member

@syuilo syuilo commented May 15, 2026

What

Why

手元の検証で動作が確認された

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions
Copy link
Copy Markdown
Contributor

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 24.82%. Comparing base (1684dc9) to head (72a4413).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #17405   +/-   ##
========================================
  Coverage    24.82%   24.82%           
========================================
  Files         1156     1156           
  Lines        39330    39330           
  Branches     10948    10948           
========================================
  Hits          9762     9762           
  Misses       23694    23694           
  Partials      5874     5874           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

Backend memory usage comparison

Before GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 318.60 MB 306.53 MB -12.07 MB -3.78%
VmHWM 318.60 MB 306.53 MB -12.07 MB -3.78%
VmSize 23183.64 MB 23170.73 MB -12.91 MB -0.05%
VmData 1383.66 MB 1372.12 MB -11.54 MB -0.83%

After GC

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 318.68 MB 306.89 MB -11.78 MB -3.69%
VmHWM 318.68 MB 306.89 MB -11.78 MB -3.69%
VmSize 23183.64 MB 23171.06 MB -12.57 MB -0.05%
VmData 1383.66 MB 1372.45 MB -11.20 MB -0.80%

After Request

Metric base (MB) head (MB) Diff (MB) Diff (%)
VmRSS 319.00 MB 307.29 MB -11.70 MB -3.66%
VmHWM 319.00 MB 307.29 MB -11.70 MB -3.66%
VmSize 23183.64 MB 23171.06 MB -12.57 MB -0.05%
VmData 1383.66 MB 1372.45 MB -11.20 MB -0.80%

See workflow logs for details

@samunohito
Copy link
Copy Markdown
Member

https://github.com/misskey-dev/misskey/blob/develop/.github/workflows/test-backend.yml#L35-L37
https://github.com/misskey-dev/misskey/blob/develop/.github/workflows/test-federation.yml#L31-L33

↑のあたりに手を入れてv26も確認するようにするのが安牌だと思いましたが、どうでしょう

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor

nsfw検出がnode 22でしかまともに動かないのでまだデフォルトは上げられなさそう

See #16944

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor

↑のあたりに手を入れてv26も確認する

これデフォルトバージョンを更新することになる

@anatawa12
Copy link
Copy Markdown
Member

新たに.node-versionファイルはやしてそれのパスを追加するのがよさそうな気がします

@samunohito
Copy link
Copy Markdown
Member

新たに.node-versionファイルはやしてそれのパスを追加するのがよさそうな気がします

こっちの意図でした

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/backend Server side specific issue/PR

Projects

Development

Successfully merging this pull request may close these issues.

4 participants