Skip to content

refactor(frontend): ロールポリシーエディタを統合#17125

Merged
syuilo merged 10 commits intomisskey-dev:developfrom
kakkokari-gtyih:refactor-unify-rolepolicyeditor-2
Apr 15, 2026
Merged

refactor(frontend): ロールポリシーエディタを統合#17125
syuilo merged 10 commits intomisskey-dev:developfrom
kakkokari-gtyih:refactor-unify-rolepolicyeditor-2

Conversation

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor

What

#16262 (comment) だけやった

Why

Fix #14584
Close #16262

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Jan 23, 2026
@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jan 23, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 14.92%. Comparing base (a18c909) to head (46278f2).
⚠️ Report is 28 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #17125       +/-   ##
============================================
- Coverage    63.65%   14.92%   -48.74%     
============================================
  Files         1161      242      -919     
  Lines       116313    11866   -104447     
  Branches      8407     4015     -4392     
============================================
- Hits         74042     1771    -72271     
+ Misses       40063     7931    -32132     
+ Partials      2208     2164       -44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kakkokari-gtyih kakkokari-gtyih marked this pull request as draft January 23, 2026 16:26
@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review January 23, 2026 16:56
@kakkokari-gtyih
Copy link
Copy Markdown
Contributor Author

👀

@syuilo
Copy link
Copy Markdown
Member

syuilo commented Apr 11, 2026

/preview

1 similar comment
@syuilo
Copy link
Copy Markdown
Member

syuilo commented Apr 11, 2026

/preview

@syuilo
Copy link
Copy Markdown
Member

syuilo commented Apr 11, 2026

ベースロールのポリシーを編集しようとしても反応しないかも

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor Author

今日か明日みる

@kakkokari-gtyih
Copy link
Copy Markdown
Contributor Author

たぶんなおった

@syuilo
Copy link
Copy Markdown
Member

syuilo commented Apr 15, 2026

/preview

@syuilo
Copy link
Copy Markdown
Member

syuilo commented Apr 15, 2026

大丈夫そう

@syuilo syuilo merged commit c95aef7 into misskey-dev:develop Apr 15, 2026
22 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in [実験中] 管理用 Apr 15, 2026
@syuilo
Copy link
Copy Markdown
Member

syuilo commented Apr 15, 2026

👍🏻

@kakkokari-gtyih kakkokari-gtyih deleted the refactor-unify-rolepolicyeditor-2 branch April 15, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/frontend Client side specific issue/PR size:XXL This PR changes 1000+ lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

RolePoliciesのコンパネにコピペされている部分を小さなコンポーネントに切り出してもいいかもしれない

2 participants