chore(backend): FileServerServiceのunit-testを追加#17086
Merged
syuilo merged 3 commits intomisskey-dev:developfrom Jan 11, 2026
Merged
chore(backend): FileServerServiceのunit-testを追加#17086syuilo merged 3 commits intomisskey-dev:developfrom
syuilo merged 3 commits intomisskey-dev:developfrom
Conversation
Contributor
|
このPRによるapi.jsonの差分 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #17086 +/- ##
============================================
+ Coverage 14.03% 63.58% +49.55%
============================================
Files 238 1156 +918
Lines 11296 115429 +104133
Branches 3736 8147 +4411
============================================
+ Hits 1585 73397 +71812
- Misses 7586 39856 +32270
- Partials 2125 2176 +51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Backend Memory Usage Comparison
|
Member
|
👍 |
5 tasks
m10i-0nyx
pushed a commit
to foundation0-link/misskey
that referenced
this pull request
Feb 7, 2026
* add test * fix * fix type error
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
FileServerServiceのテストを追加しました(現実装を正とし、カバレッジを確保する形で対応)。
FileServerServiceを直接呼び出すわけでは無く、Fastify経由で呼び出すようにしています。Fastify/HTTPにまつわる処理が多いための措置です。
Why
動作確認をしやすくするため
Additional info (optional)
ローカルでpassを確認
Checklist