Skip to content

chore(backend): FileServerServiceのunit-testを追加#17086

Merged
syuilo merged 3 commits intomisskey-dev:developfrom
samunohito:chore/add-file-server-service-test
Jan 11, 2026
Merged

chore(backend): FileServerServiceのunit-testを追加#17086
syuilo merged 3 commits intomisskey-dev:developfrom
samunohito:chore/add-file-server-service-test

Conversation

@samunohito
Copy link
Copy Markdown
Member

What

FileServerServiceのテストを追加しました(現実装を正とし、カバレッジを確保する形で対応)。
FileServerServiceを直接呼び出すわけでは無く、Fastify経由で呼び出すようにしています。Fastify/HTTPにまつわる処理が多いための措置です。

Why

動作確認をしやすくするため

Additional info (optional)

ローカルでpassを確認

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@dosubot dosubot Bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jan 9, 2026
@github-actions github-actions Bot added packages/backend Server side specific issue/PR packages/backend:test labels Jan 9, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 9, 2026

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.58%. Comparing base (cdb958c) to head (bc16748).
⚠️ Report is 25 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #17086       +/-   ##
============================================
+ Coverage    14.03%   63.58%   +49.55%     
============================================
  Files          238     1156      +918     
  Lines        11296   115429   +104133     
  Branches      3736     8147     +4411     
============================================
+ Hits          1585    73397    +71812     
- Misses        7586    39856    +32270     
- Partials      2125     2176       +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 9, 2026

Backend Memory Usage Comparison

Metric base head Diff
RSS 314.35 MB 341.48 MB 27.12 MB (8.62%)

⚠️ Warning: Memory usage has increased by more than 5%. Please verify this is not an unintended change.

See workflow logs for details

@syuilo syuilo merged commit 106fffd into misskey-dev:develop Jan 11, 2026
39 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in [実験中] 管理用 Jan 11, 2026
@syuilo
Copy link
Copy Markdown
Member

syuilo commented Jan 11, 2026

👍

m10i-0nyx pushed a commit to foundation0-link/misskey that referenced this pull request Feb 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

packages/backend:test packages/backend Server side specific issue/PR size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

2 participants