create LED template #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amzoeee
requested changes
Dec 5, 2025
| public static final int KPORT = 0; | ||
| public static final int KLENGTH = 60; | ||
|
|
||
| public static final double BLINK_TIME = 1; // in seconds for after intake/outtake |
Member
There was a problem hiding this comment.
This variable seems to be unused.
| * | ||
| * @param pattern the LED pattern to run | ||
| */ | ||
| public Command runPattern(LEDPattern pattern) { |
Member
There was a problem hiding this comment.
Can you add names to all of these commands with .withName("[color/pattern]")? This way, when we log the subsystem, we'll be able to see what command is running on it (in case we need to debug, this will make our lives much easier).
| // Set the default command to turn the strip off, otherwise the last colors written by | ||
| // the last command to run will continue to be displayed. | ||
| // Note: Other default patterns could be used instead! | ||
| setDefaultCommand((runScrollingRedBlueCommand()).withName("Off")); |
Member
There was a problem hiding this comment.
Can we change the name of this command to something like "Default colors" or something?
| return runPattern(gradient); | ||
| } | ||
|
|
||
| public Command runScrollingRedBlueCommand(){ |
Member
There was a problem hiding this comment.
Why is it red and blue? :( I liked blue + yellow better--they're our team colors! /hj
| Distance ledSpacing = Meters.of(1 / 60.0); | ||
| LEDPattern base = LEDPattern.gradient(LEDPattern.GradientType.kDiscontinuous, Color.kRed, Color.kBlue); | ||
| LEDPattern pattern = base.scrollAtRelativeSpeed(Percent.per(Second).of(100)); | ||
| LEDPattern absolute = base.scrollAtAbsoluteSpeed(Centimeters.per(Second).of(6.25), ledSpacing); |
Member
There was a problem hiding this comment.
Seems to be unused code. Not sure if we want to keep it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same as Dynamene code
placeholder for constants
not tested