feat(commands): implement reserves and encodes subcommands#5
Merged
Conversation
Add comprehensive reservation and encoding management functionality: - feat(reserves): implement complete reservation management - List reservations with filtering by type, rule ID, pagination - Show detailed reservation information - Create, update, and delete reservations - Handle reservation conflicts, skips, and overlaps - Display reservation status summaries and counts - Trigger reservation system updates - feat(encodes): implement encoding job management - List running and queued encoding jobs with progress - Add new manual encoding jobs for recorded content - Cancel active or queued encoding jobs - Show encoding system status - feat(client): extend wrapper with reserves and encodes API methods - Add comprehensive wrapper methods for all reserves endpoints - Add encoding job management methods - Maintain consistent error handling and response processing - docs(readme): update documentation with new commands - Add reservation and encoding management feature descriptions - Include comprehensive usage examples for all subcommands - Update project structure documentation All commands follow existing CLI patterns and support both table and JSON output formats.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| addCmd.Flags().BoolVar(&saveSameDirectory, "save-same-dir", false, "Save in same directory as original") | ||
|
|
||
| // Mark required flags | ||
| addCmd.MarkFlagRequired("recorded-id") |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Error return value of addCmd.MarkFlagRequired is not checked (errcheck)
|
|
||
| // Mark required flags | ||
| addCmd.MarkFlagRequired("recorded-id") | ||
| addCmd.MarkFlagRequired("mode") |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
Error return value of addCmd.MarkFlagRequired is not checked (errcheck)
|
|
||
| var formatter output.Formatter | ||
| switch cfg.Output.Format { | ||
| case "json": |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
string json has 3 occurrences, make it a constant (goconst)
|
|
||
| var formatter output.Formatter | ||
| switch cfg.Output.Format { | ||
| case "json": |
There was a problem hiding this comment.
🚫 [golangci] reported by reviewdog 🐶
string json has 4 occurrences, make it a constant (goconst)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements comprehensive reserves and encodes subcommand functionality for epgstationctl, providing full access to EPGStation's reservation management and encoding operations through the command line interface.
✅ Reserves Command (
epgstationctl reserves)✅ Encodes Command (
epgstationctl encodes)🔧 Technical Implementation
📚 Documentation
Test plan
Related Tasks
Implements the complete reserves and encodes functionality as requested, providing:
Other
This implementation provides the foundation for complete EPGStation management through the CLI, significantly expanding the tool's capabilities beyond the existing channels, programs, recordings, and rules commands.