Fix programs command table formatting and improve output readability#2
Merged
Fix programs command table formatting and improve output readability#2
Conversation
…a structures - Add custom formatSchedulesAsTable function to display program schedules in readable table format - Flatten nested schedule data to show channel name, program name, times, and descriptions - Add formatUnixTime helper to convert timestamps to HH:MM format - Improve table formatter to handle nested structs without showing memory addresses - Fix programs current command to show clean, user-friendly output - Ensure consistent formatting across all programs commands (list, current, search) - Maintain JSON output compatibility for automation scripts Fixes issues with programs current command showing Go struct internals instead of readable data.
Signed-off-by: Kotaro Inoue <k.musaino@gmail.com>
Signed-off-by: Kotaro Inoue <k.musaino@gmail.com>
- Fix errcheck issues by properly handling resp.Body.Close() errors - Fix unused variable 'keyword' in programs command - Fix unnecessary type conversions for type aliases (ChannelId, Offset, Limit, Days) - Fix goconst issue by creating outputFormatJSON constant - Fix unchecked fmt.Fprintln error return - Update .golangci.yml to modern configuration format with proper version - Add comprehensive linting rules including errcheck, unused, unconvert, goconst All golangci-lint issues resolved while maintaining functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Key Changes
Programs Command Improvements
formatSchedulesAsTable()function that flattens nested schedule data into readable table formatformatUnixTime()helper to convert Unix timestamps to HH:MM format for better readabilityTable Formatter Enhancements
Testing
✅ Tested Commands:
programs current- Now displays clean table with channel names, program names, times, and descriptionsprograms search- Works correctly with improved formattingchannels list/show- Continues to work properlyrecordings list/status- Functions correctly✅ Test Server: Verified against EPGStation server at
http://popplio.foxhound-kelvin.ts.net:8888Related Tasks
Addresses output formatting issues identified during comprehensive CLI testing. Maintains backward compatibility while significantly improving user experience.
Other