Support for Unicode Roman Numerals (e.g. Ⅳ, Ⅷ, etc.)#4
Open
vanviethieuanh wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
As what we discussed in this discussion I implemented:
fn from_char(c: char) -> Result<Vec<Digit>>.archaicbecause characters likeↈis rarely used.Vec<Digit>.As suggestion:
Now
Roman::from_strcould parse mixing string likeXⅦ. However, because Unicode characters likeⅦis more than 1 byte usingfrom_bytehave to becomefrom_charand result of map become 2D Vec instead. As a result, it ~5 times slower than the original (tested onmmmdcccxciiicase) and we have to change most of the code inRoman::from_str.I tried to use both
collect.iter.flattenandforwithextendto avoid changing your code. But with this, performance drop even more (~7-10 times slower). This is all I could do to preserve your logic, please let me know if you want to revert what I changed in Roman