Warn on base ref parse failures instead of silently ignoring#8
Merged
Conversation
load_base_entries was catching all exceptions silently, which caused removal detection to fail when the base ref had a malformed bib entry. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Citations Summary
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
load_base_entrieswas catching all exceptions silently, returning an empty dict on parse errorsRoot cause of the failed re-sync: the base ref
76df543had a malformed BibTeX entry (@article{doi:10.1126/...}) that caused the parser to choke silently.Test plan
2ebfd31(clean state before PR Update references.bib by removing articles #5)🤖 Generated with Claude Code