Skip to content

fix: ensure separate sessions for each client instance #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fguillot merged 1 commit into from
Jan 16, 2026
Merged

fix: ensure separate sessions for each client instance #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions miniflux.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ def __init__(
timeout: float = 30.0,
api_key: Optional[str] = None,
user_agent: str = DEFAULT_USER_AGENT,
session: requests.Session = requests.Session(),
session: Optional[requests.Session] = None,
):
"""
Initializes the Miniflux API client.
Expand Down Expand Up @@ -141,7 +141,7 @@ def __init__(

self._base_url = base_url.rstrip("/")
self._timeout = timeout
self._session = session
self._session = session or requests.Session()

self._session.headers.update({"User-Agent": user_agent})
if api_key:
Expand Down
8 changes: 8 additions & 0 deletions tests/test_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,14 @@ def test_get_error_reason(self):
self.assertEqual(error.status_code, 404)
self.assertEqual(error.get_error_reason(), "some error")

def test_default_session_not_shared(self):
client_one = miniflux.Client("http://localhost", api_key="token-one")
client_two = miniflux.Client("http://localhost", api_key="token-two")

self.assertIsNot(client_one._session, client_two._session)
self.assertEqual(client_one._session.headers.get("X-Auth-Token"), "token-one")
self.assertEqual(client_two._session.headers.get("X-Auth-Token"), "token-two")

def test_get_error_without_reason(self):
response = mock.Mock()
response.status_code = 404
Expand Down