Fixes issue #905 on the maintenance branch

[michelebastione]

Mirrors changes made in #906 on the maintenance branch

[gemini-code-assist]

Summary of Changes

Hello @michelebastione, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses issue #905 by incorporating changes previously made in #906, specifically focusing on improving resource management for asynchronous operations within the MiniExcel library. The primary goal is to ensure that asynchronous write adapters are properly disposed of, enhancing the robustness of CSV and OpenXML writing functionalities when dealing with asynchronous data sources.

Highlights

• Resource Management for Async Operations: Implemented IAsyncDisposable and try-finally blocks in CsvWriter and ExcelOpenXmlSheetWriter.Async to ensure proper disposal of asynchronous write adapters, preventing potential resource leaks.
• AsyncEnumerableWriteAdapter Enhancements: The AsyncEnumerableWriteAdapter now correctly handles cancellation tokens during enumeration and ensures its own disposal by implementing IAsyncDisposable.
• Code Refinements and Maintenance: Includes a safer casting method in MiniExcelWriteAdapterFactory and an update to the .gitignore file to exclude test data.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses a potential resource leak by ensuring IAsyncDisposable adapters are properly disposed. The introduction of try-finally blocks in CsvWriter and ExcelOpenXmlSheetWriter is a good practice for robust resource management. The changes in AsyncEnumerableWriteAdapter to implement IAsyncDisposable and use ValueTask are well done. I've found one medium-severity issue related to cancellation token propagation that could be improved.