Skip to content

Conversation

@Matios102
Copy link
Contributor

@Matios102 Matios102 commented Dec 9, 2025

This pull request introduces integration testing for RabbitMQ functionality and improves the CI workflow to support these tests and more granular coverage reporting. The main changes include adding new integration test files for RabbitMQ connections and consumers, updating the GitHub Actions workflow to start RabbitMQ and Docker services for tests, splitting unit and integration test coverage, and providing a helper script for running integration tests locally.

Integration Testing Support

  • Added new integration tests for RabbitMQ connection and channel operations in internal/rabbitmq/connection_integration_test.go, covering connection establishment, channel creation, queue declaration, and message publishing/consumption.
  • Added a new integration test for the consumer's handshake message processing in internal/rabbitmq/consumer/consumer_integration_test.go.

CI/CD Workflow Enhancements

  • Updated .github/workflows/publish-coverage.yaml to start docker and rabbitmq services for the test job, enabling integration tests to run in CI.
  • Split test execution into unit and integration tests with separate coverage profiles, then merged the coverage reports before uploading to Codecov.

Developer Tooling

  • Added a run_integration_tests.sh script to automate running integration tests locally, including starting RabbitMQ via Docker Compose and handling platform-specific Docker configuration.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces integration tests for the Docker client and updates the CI workflow to run both unit and integration tests separately with merged coverage reporting. The changes improve test coverage for Docker operations and ensure that Docker is available during CI runs.

Key Changes:

  • Added comprehensive integration tests for Docker client operations including container lifecycle, image management, and volume operations
  • Created a platform-aware shell script to facilitate running integration tests locally
  • Updated GitHub Actions workflow to run unit and integration tests separately, then merge coverage reports using gocovmerge

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.

File Description
internal/docker/docker_client_integration_test.go Adds 14 integration tests covering Docker client functionality including container creation, image pulling, volume mounting, and container lifecycle management
run_integration_tests.sh Provides a platform-aware script that detects OS (macOS, Linux, Windows), configures Docker host, verifies Docker daemon accessibility, and runs integration tests
.github/workflows/publish-coverage.yaml Updates CI workflow to start Docker service, run unit and integration tests separately, merge coverage reports, and upload to Codecov with error handling

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 16 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Matios102 Matios102 marked this pull request as draft December 11, 2025 15:10
@Matios102 Matios102 changed the title feat: add integration tests for Docker client and update CI workflow feat: add integration tests for Docker client and RabbitMq Jan 11, 2026
@Matios102 Matios102 marked this pull request as ready for review January 11, 2026 12:15
@Matios102 Matios102 merged commit e93722b into master Jan 11, 2026
1 check passed
@Matios102 Matios102 deleted the test/integration-tests branch January 11, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants