Skip to content

Fix typos and SQL syntax errors in README examples#12432

Open
thzgajendra wants to merge 1 commit into
mindsdb:mainfrom
thzgajendra:docs/fix-readme-sql-examples
Open

Fix typos and SQL syntax errors in README examples#12432
thzgajendra wants to merge 1 commit into
mindsdb:mainfrom
thzgajendra:docs/fix-readme-sql-examples

Conversation

@thzgajendra
Copy link
Copy Markdown

Summary

  • Line 114: Fix typo MondoDBMongoDB
  • Line 140: Fix incorrect delimiter in CREATE KNOWLEDGE_BASE — semicolon should be a comma so metadata_columns is included in the statement
  • Line 147: Fix broken WHERE clause — period after 'true' replaced with proper AND operator so revenue > 1000000 condition is applied

- Fix "MondoDB" → "MongoDB" typo
- Fix incorrect semicolon delimiter in CREATE KNOWLEDGE_BASE (should be comma)
- Fix broken WHERE clause: replace period with AND operator
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 7, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@thzgajendra
Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

@entelligence-ai-pr-reviews
Copy link
Copy Markdown
Contributor

EntelligenceAI PR Summary

This PR corrects three errors in README.md to improve accuracy and validity of documented SQL syntax.

  • Fixed typo: MondoDBMongoDB
  • Replaced semicolon with comma in CREATE KNOWLEDGE_BASE statement to fix invalid SQL syntax
  • Corrected malformed WHERE clause by replacing a period with a newline and adding missing AND keyword to properly chain the revenue > 1000000 condition

Confidence Score: 5/5 - Safe to Merge

Safe to merge — this PR makes three straightforward documentation corrections in README.md with no code or logic changes. The fixes address a clear typo (MondoDBMongoDB), a SQL syntax error (semicolon replaced with comma in the CREATE KNOWLEDGE_BASE statement), and a malformed WHERE clause (missing newline and AND keyword for the revenue > 1000000 condition). All changes improve the accuracy and validity of documented examples without introducing any risk.

Key Findings:

  • The MondoDBMongoDB typo fix is unambiguously correct and purely cosmetic in impact.
  • The semicolon-to-comma correction in the CREATE KNOWLEDGE_BASE SQL example fixes genuinely invalid syntax that could mislead users trying to replicate the example.
  • The WHERE clause correction — adding a newline and AND keyword before revenue > 1000000 — restores proper SQL chaining logic that was malformed in the original documentation.
  • No automated review comments were generated, and there are no existing unresolved concerns; the PR scope is limited entirely to README.md documentation fixes.
Files requiring special attention
  • README.md

github-actions Bot added a commit that referenced this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant