Skip to content

Fix tests_integration.yml#12398

Open
OpenByteDev wants to merge 1 commit into
mindsdb:mainfrom
OpenByteDev:patch-1
Open

Fix tests_integration.yml#12398
OpenByteDev wants to merge 1 commit into
mindsdb:mainfrom
OpenByteDev:patch-1

Conversation

@OpenByteDev
Copy link
Copy Markdown

Description

Removes the invalid secrets key under workflow_dispatch which doesnt exist according to https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#onworkflow_dispatch.

Type of change

(Please delete options that are not relevant)

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ⚡ New feature (non-breaking change which adds functionality)
  • 📢 Breaking change (fix or feature that would cause existing functionality not to work as expected)
  • 📄 This change requires a documentation update

Verification Process

Not applicable

Additional Media:

Not applicable

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@OpenByteDev OpenByteDev requested a review from a team as a code owner April 21, 2026 14:34
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 21, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@entelligence-ai-pr-reviews
Copy link
Copy Markdown
Contributor

EntelligenceAI PR Summary

Removes the OPENAI_API_KEY secret dependency from the integration tests CI workflow's workflow_call trigger.

  • Eliminates OPENAI_API_KEY from the secrets block under workflow_call in .github/workflows/tests_integration.yml
  • Calling workflows no longer need to pass this secret when invoking the integration tests workflow

Confidence Score: 5/5 - Safe to Merge

Safe to merge — this PR makes a targeted, well-scoped change to .github/workflows/tests_integration.yml by removing the OPENAI_API_KEY secret from the workflow_call secrets block, which simplifies the interface for callers of this reusable workflow. The change correctly reflects that callers no longer need to pass this secret when invoking the integration tests workflow. No logic, runtime, or security regressions are introduced; if anything, removing an unnecessary secret dependency reduces the exposure surface for that credential.

Key Findings:

  • Removing OPENAI_API_KEY from the workflow_call secrets block is a clean simplification — it reduces the coupling between calling workflows and this reusable workflow without breaking any functionality, assuming the secret is no longer needed at the workflow invocation level.
  • No new logic, runtime paths, or security concerns are introduced; the change is purely a CI configuration adjustment with no impact on application code.
  • The PR is minimal and focused — exactly one conceptual change in one file — making it easy to reason about the full scope of impact.
  • No review comments, unresolved threads, or heuristic issues were flagged, and the change aligns with the stated PR summary.
Files requiring special attention
  • .github/workflows/tests_integration.yml

@OpenByteDev
Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

github-actions Bot added a commit that referenced this pull request Apr 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant