Skip to content

MOBILE-188: merge with develop and added migration guide#178

Open
sergeysozinov wants to merge 3 commits into
new-archfrom
feature/MOBILE-188
Open

MOBILE-188: merge with develop and added migration guide#178
sergeysozinov wants to merge 3 commits into
new-archfrom
feature/MOBILE-188

Conversation

@sergeysozinov
Copy link
Copy Markdown
Collaborator

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR merges updates from develop and introduces a documented migration path to SDK 3.0.0, while extending initialization to optionally pass an operationsDomain through JS → native (iOS/Android).

Changes:

  • Added optional operationsDomain to initialization payload (TS + iOS + Android).
  • Removed deprecated JS API updateNotificationPermissionStatus and documented the replacement.
  • Added MIGRATION_GUIDE.md covering 2.x → 3.x breaking changes and integration steps.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/types/InitializationData.ts Adds operationsDomain?: string to the public initialization type.
src/index.tsx Passes operationsDomain into the native initialize payload; removes deprecated API.
src/tests/index.test.ts Adds coverage for operationsDomain payload inclusion/exclusion.
ios/MindboxSdkImpl.swift Adds operationsDomain to the decode/configuration path.
android/src/main/java/com/mindboxsdk/MindboxSdkModule.kt Applies operationsDomain to the Android configuration builder.
MIGRATION_GUIDE.md Documents breaking changes and migration steps for 3.0.0.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/index.tsx
Comment thread android/src/main/java/com/mindboxsdk/MindboxSdkModule.kt
Comment thread MIGRATION_GUIDE.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants