Conversation
There was a problem hiding this comment.
Pull request overview
Automated post-release merge of master back into develop for SDK version 2.15.1. The diff bundles together the changes that shipped in the 2.15.1 release: a version bump, narrowed/cleaned ProGuard consumer rules, explicit @SerializedName annotations on bridge message and webview payload data classes (to survive R8 minification), and a substantial set of new unit tests for Gson type adapters.
Changes:
- Bump
SDK_VERSION_NAMEand example app dependency from 2.15.0 → 2.15.1. - Tighten consumer ProGuard rules (drop broad
inapp.data**keep andenum models**member rule; add narrowerinapp.data.dto.**rule; remove the unusedandroid.preference.Preferencekeep). - Add
@SerializedNameannotations toBridgeMessage.{Request,Response,Error}fields and toNavigationInterceptedPayload.url/ErrorPayload.error. - Add unit tests for
IdsAdapter,CustomerFieldsAdapter,DateOnlyAdapter,DateTimeAdapter,ProductListResponseAdapter, andMindboxErrorAdapter.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| gradle.properties | SDK version bump 2.15.0 → 2.15.1. |
| example/app/build.gradle | Sample app pulls released 2.15.1 artifact. |
| sdk/consumer-rules.pro | Narrows ProGuard keep rules; drops enum keep and Preference rule. |
| sdk/src/main/java/.../WebViewAction.kt | Adds explicit @SerializedName to all BridgeMessage subtypes. |
| sdk/src/main/java/.../WebViewInappViewHolder.kt | Adds @SerializedName to inner payload data classes. |
| sdk/src/test/.../IdsAdapterTest.kt | New tests covering numeric/string ID handling and round-trip. |
| sdk/src/test/.../CustomerFieldsAdapterTest.kt | New tests for CustomFields (de)serialization and convertTo. |
| sdk/src/test/.../DateOnlyAdapterTest.kt | New tests for yyyy-MM-dd parsing/writing and null/error handling. |
| sdk/src/test/.../DateTimeAdapterTest.kt | New tests for ISO-8601 parsing and write format. |
| sdk/src/test/.../ProductListResponseAdapterTest.kt | New tests for array vs object dispatch. |
| sdk/src/test/.../MindboxErrorAdapterTest.kt | New tests documenting toJson shape and the broken read path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Pull Request to merge 'master' into 'develop' after release