Conversation
Collaborator
Author
|
@tomMoral, now would be a good time for a review, before the number of lines changes is too big :) The experiment files |
tomMoral
approved these changes
Jul 8, 2025
Collaborator
tomMoral
left a comment
tomMoral
left a comment
There was a problem hiding this comment.
A few comments but overall LGTM
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
…ne_, alpha_, kernel_, baseline_noise
tomMoral
reviewed
Jul 15, 2025
Collaborator
tomMoral
left a comment
tomMoral
left a comment
There was a problem hiding this comment.
A few comment but otherwise, lgtm to merge like this
| ] | ||
|
|
||
| experiments = [ | ||
| "dicodile>=0.3", |
Collaborator
There was a problem hiding this comment.
Why do we need dicodile? To get the gait data?
Collaborator
Author
There was a problem hiding this comment.
Yes exactly. There are a few packages we need just for the ECG and gait experiments. I'll add them here.
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
vloison
changed the title
Collaborator
Author
|
This PR is now ready to merge on my side, @tomMoral do you want to check the latest updates or is it good to go? :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To do :
[x] homogenize docstring of FaDIn and UNHaP
[x] Add solvers benchmarked in the UNHaP paper
[x] Add UNHaP experiments
[x] Update README
[ ] Update pyproject.toml with optional dependencies for experiments.
[ ] More beginner-friendly tutorials.
[ ] More doc for UNHaP and its utility functions.
To do in a future PR:
[ ] Factorize UNHaP and FaDIn utility functions
This will not be so easy. For instance, during optimization, model parameters are stored as a list. And UNHaP has one more model parameter, the noise baseline. Another example: for fadin, events are floats, for unhap, they are arrays of size two. This means that between the two solvers, several functions have lots of code in common but are tricky to factorize robustly.
[x] add tests for UNHaP and FaDIn: