feat: add kplane storage implementation#635
Open
savme wants to merge 2 commits into
Open
Conversation
5bf9cf3 to
17e2cf4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #596.
Alternative implementation in #647.
What
Adds a
kplanestorage implementation to Milo.Numbers
Scale benchmark; 100 projects across 5 runs (using the harness from #615):
How to try it
Notes
Toolchain bumps required by the kplane fork:
sigs.k8s.io/controller-runtime: 0.23.3 → 0.24.1sigs.k8s.io/multicluster-runtime: 0.23.3 → 0.24.1k8s.io/{api,apimachinery,apiserver,client-go,component-base,...}: v0.35.0 → v0.36.0k8s.io/client-go v1.5.2appears in go.mod per kplane's require https://github.com/kplane-dev/apiserver/blob/main/go.mod#L17Test plan
go build ./...cleango vet ./...cleango test ./...(unit) cleantask dev:setup:kplanebrings apiserver up with the flag (verified via thekplane shared-cacherlog line)task test:scaleagainst kplane backend produces the numbers above