feat: add Milo IAM for graph.inventory.miloapis.com (v1alpha2)#45
Open
ecv wants to merge 1 commit into
Open
Conversation
The v1alpha2 property-graph API (group graph.inventory.miloapis.com,
kinds Node/Edge/NodeType/EdgeType) had no ProtectedResources or Roles, so
every verb on it is Forbidden. Add them mirroring the existing
inventory.miloapis.com IAM.
- protected-resources/graph-{node,edge,nodetype,edgetype}.yaml register
the four kinds so graph.inventory.miloapis.com/<plural>.<verb>
permission strings become addressable.
- roles/graph-{viewer,editor,admin,operator}.yaml — group-wide roles in
milo-system, same semantics as the inventory.miloapis.com-* roles.
- Wire both into the iam kustomizations; document the group in the README.
Bindings remain per-environment (granted in datum-cloud/infra).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds Milo IAM (
ProtectedResource+Role) for the v1alpha2 property-graph groupgraph.inventory.miloapis.com(kindsNode,Edge,NodeType,EdgeType).These had no IAM, so every verb on the graph group is
Forbidden— the datumctl plugin reaches the API but gets denied (datum-cloud/inventory#10 verification). Mirrors the existinginventory.miloapis.comIAM in this package.Changes
protected-resources/graph-{node,edge,nodetype,edgetype}.yaml— register the four kinds sograph.inventory.miloapis.com/<plural>.<verb>permission strings are addressable.roles/graph-{viewer,editor,admin,operator}.yaml— group-wide roles inmilo-system, same semantics as theinventory.miloapis.com-*roles (viewer = read; editor = +write; admin inherits editor; operator = read + update/patch for the controller).kustomize build config/base/iampasses.Scope
Definitions only.
PolicyBindinggrants to specific principals are per-environment and live in datum-cloud/infra (separate PR).Part of datum-cloud/inventory#9 (RBAC needed for the v1alpha2 plugin). Pairs with a datum-cloud/infra PR that binds these roles.