feat(quota): add display name/description to the billing-accounts quota limit#59
Open
yahyafakhroji wants to merge 1 commit into
Open
feat(quota): add display name/description to the billing-accounts quota limit#59yahyafakhroji wants to merge 1 commit into
yahyafakhroji wants to merge 1 commit into
Conversation
… quota limit Populate displayName/description on the billing-accounts-per-organization quota limit so the service-catalog quota fan-out stamps kubernetes.io/display-name and kubernetes.io/description on the generated billing.miloapis.com/billingaccount/count ResourceRegistration. Portals (cloud-portal Quotas) then render "Billing Accounts" instead of the raw metric key. Requires the QuotaLimitSpec display fields from milo-os/service-catalog#41.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add
displayName: Billing Accounts+ adescriptionto thebilling-accounts-per-organizationentry underspec.quota.limitsin the billingServiceConfiguration.Why
The service-catalog quota fan-out builds the
billing.miloapis.com/billingaccount/countResourceRegistrationfrom the limit (not the metric). With these fields set it stampskubernetes.io/display-name/kubernetes.io/description, so portals (cloud-portal Quotas) render "Billing Accounts" instead of the raw metric key. The metric already carried a display name; this brings the quota limit to parity.Depends on milo-os/service-catalog#41 (adds
DisplayName/DescriptiontoQuotaLimitSpec), now merged. This should be rolled out after a service-catalog build containing #41 is deployed — applying the new fields against an older CRD would be rejected as unknown fields.Related