MILAB-5374: new tests with docker ep/cmd constraints

[DenKoren]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: 782ff26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[notion-workspace]

[backend] Always put actual docker image’s entrypoint to sw.json file

[gemini-code-assist]

Summary of Changes

Hello @DenKoren, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the testing framework by establishing a dedicated @platforma-open/milaboratories.software-test-utils package. This new package centralizes test-related software, facilitating better organization and maintainability. The primary impact is the addition of new, robust tests that specifically verify the correct handling of Docker entrypoint and command constraints, ensuring the reliability of Dockerized software execution within the platform's workflows. This refactoring and expansion of test coverage contribute to a more stable and predictable development environment.

Highlights

• Test Utilities Migration: Migrated various software imports from the legacy @platforma-open/milaboratories.software-small-binaries package to the newly introduced @platforma-open/milaboratories.software-test-utils package across several workflow templates and test files. This centralizes test-related software for better organization.
• New Docker Constraint Tests: Added two new concurrent tests, check-docker-entrypoint-preserved and check-docker-cmd-preserved, to rigorously validate that Docker's original entrypoint and command parameters are correctly preserved during software execution within the workflow system.
• Dependency Updates: Updated package.json, pnpm-lock.yaml, and pnpm-workspace.yaml files to correctly include the new @platforma-open/milaboratories.software-test-utils package and reflect necessary version changes for related dependencies.
• New Tengo Template for Docker Tests: Introduced a new Tengo template file, docker_constraints.tpl.tengo, specifically designed to support the new Docker constraint tests by importing and executing test-specific software to verify Docker behavior.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates several Tengo templates and package configurations to migrate from @platforma-open/milaboratories.software-small-binaries to @platforma-open/milaboratories.software-test-utils. New test cases for Docker entrypoint and command constraints have also been introduced, which is a good addition for ensuring robust behavior. The changes generally reflect a shift towards a dedicated test utility package.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.97%. Comparing base (0044f7f) to head (782ff26).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1384   +/-   ##
=======================================
  Coverage   52.97%   52.97%           
=======================================
  Files         238      238           
  Lines       13293    13293           
  Branches     2722     2722           
=======================================
  Hits         7042     7042           
  Misses       5354     5354           
  Partials      897      897           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.