Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two bugs identified by issue #95:
Union members identified using oneof require a title option if defined directly, otherwise the object name is empty which is not valid. The logic used to catch this was incomplete and results either in a python recursion error if there are multiple such definitions, or invalid code being generated if only one such un-titled definition exists. Both situations are confusing, so an additional check has been added which catches this issue during code generation.
Generated classes may not be in the correct order, resulting in compilation errors such as 'struct not yet fully defined'. This was due to to a bug when sorting dependencies with nested definitions. Sample config pr96-recur.cfgdb added to test.