refactor(core): inline gateway model factory into AgentSessionDO#8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
AgentSessionDOinitialization and model-switch paths self-contained so tests can reliably override the model via_setModelForTest()inside the Durable Object.Description
createModel(env, modelId)helper andai-gateway-providerimports directly inpackages/core/src/agent-session-do.tsand used it for initialization and model-switching.packages/core/src/gateway.tsfile.packages/core/test/do/mock-model.tscomments to reference the inlined helper location.specs/core.mdandspecs/implementation_plan.mdto point at the newcreateModel()location so spec and code remain aligned.Testing
pnpm -r exec tsc --noEmit, which completed successfully.Codex Task