Conversation
Bumps all the requests version to V4
Also remove previous requests as they do not exist anymore and add the new `#champion_rotations` method which is the only request remaining. Removed unused fixtures and added the new request fixture.
This was deprecated for DataDragon
This was also deprecated, these does not exist anymore.
While the Runes still exist, there doesn't seem to be a request for runes anymore.
Open
|
@intinig this will be merged? |
Author
|
I never got a response back from him. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks @fusillicode, I saw your branch and based of it to complete my requirements.
I also removed a lot of unused Requests, fixtures, etc. I fixed all the specs and corrected others.
Honestly the changes made by the V4 are mostly fixed by changing the URL as nothing else changes. I was hesitant to change the method arguments as that would mean changing code in my app, but just for consistency to what @fusillicode had already started I sticked with it.